From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.bugs,gmane.emacs.erc.general Subject: bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt Date: Tue, 23 Jan 2024 05:25:05 +0100 Message-ID: <87zfwwism6.fsf@dataswamp.org> References: <87v87yvnly.fsf@dataswamp.org> <834jfikb4d.fsf@gnu.org> <87mstavias.fsf@dataswamp.org> <87wmseoskl.fsf@dataswamp.org> <87plxyowpg.fsf__13716.8874776521$1705633220$gmane$org@neverwas.me> <87wms1k6xg.fsf@dataswamp.org> <87plxt2yjx.fsf@neverwas.me> <87ttn5job9.fsf@dataswamp.org> <87r0i9jhp6.fsf@dataswamp.org> <87zfwxxdmn.fsf__6793.81943061657$1705958905$gmane$org@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38491"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 68401@debbugs.gnu.org Cancel-Lock: sha1:22teQamj6xxM4cuvROAa6sr+qHA= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 23 05:26:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rS8Mf-0009mJ-5Q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jan 2024 05:26:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rS8MN-0008Rn-Bg; Mon, 22 Jan 2024 23:26:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rS8MH-0008Ra-Tm for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2024 23:25:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rS8MH-0003Jp-Em for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2024 23:25:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rS8ML-0002oJ-K1 for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2024 23:26:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87v87yvnly.fsf@dataswamp.org> Resent-From: Emanuel Berg Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jan 2024 04:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68401 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170598392910768 (code B ref -1); Tue, 23 Jan 2024 04:26:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Jan 2024 04:25:29 +0000 Original-Received: from localhost ([127.0.0.1]:42044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rS8Lp-0002nc-4s for submit@debbugs.gnu.org; Mon, 22 Jan 2024 23:25:29 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:43762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rS8Ln-0002nN-0b for submit@debbugs.gnu.org; Mon, 22 Jan 2024 23:25:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rS8Lc-0008Iz-H7 for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2024 23:25:16 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rS8La-0003CT-Es for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2024 23:25:16 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rS8LY-0008Hl-80 for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 05:25:12 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org Original-Followup-To: gmane.emacs.bugs,gmane.emacs.erc.general Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278721 gmane.emacs.erc.general:2392 Archived-At: J.P. wrote: >> (defun erc-drop-leading-whitespace (str) >> (if (string-match "^ \\(.*\\)$" str) >> (match-string 1 str) >> str) ) > > Why not use `string-prefix-p' and `substring' to accomplish > this? Also, please name this using the internal "--" > convention, something like `erc--drop-initial-space-char' or > `erc--drop-single-leading-space'. Good idea to use `string-prefix-p' and `substring', but it hasn't anything to do with ERC at this point - it should be put in some string manipulation library and then ERC should `require' it. (drop-prefix "pre" "prefix") ; fix But, now I think I've done it all? Have a look to see if everyone is happy, if so I can start fiddling with the unit test patch. (defun drop-prefix (pf str) (if (string-prefix-p pf str) (substring str (length pf)) str)) (defun erc--connected-and-joined-p () (and (erc--current-buffer-joined-p) erc-server-connected)) (defun erc-cmd-GMSG (line) "Send LINE to all channels on all networks you are on." (setq line (drop-prefix " " line)) (erc-with-all-buffers-of-server nil (lambda () (erc-channel-p (erc-default-target))) (when (erc--connected-and-joined-p) (erc-send-message line)))) (put 'erc-cmd-GMSG 'do-not-parse-args t) (defun erc-cmd-AMSG (line) "Send LINE to all channels of the current network. Interactively, prompt for the line of text to send." (interactive "sSend to all channels on this network: ") (setq line (drop-prefix " " line)) (erc-with-all-buffers-of-server erc-server-process (lambda () (erc-channel-p (erc-default-target))) (when (erc--connected-and-joined-p) (erc-send-message line)))) (put 'erc-cmd-AMSG 'do-not-parse-args t) (defun erc-cmd-GME (line) "Send LINE as an action to all channels on all networks you are on." (erc-with-all-buffers-of-server nil (lambda () (erc-channel-p (erc-default-target))) (when (erc--connected-and-joined-p) (erc-cmd-ME line)))) (put 'erc-cmd-GME 'do-not-parse-args t) (defun erc-cmd-AME (line) "Send LINE as an action to all channels on the current network." (erc-with-all-buffers-of-server erc-server-process (lambda () (erc-channel-p (erc-default-target))) (when (erc--connected-and-joined-p) (erc-cmd-ME line)))) (put 'erc-cmd-AME 'do-not-parse-args t) -- underground experts united https://dataswamp.org/~incal