From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require Date: Wed, 31 Jan 2024 15:51:35 +0100 Message-ID: <87zfwlbloo.fsf@dataswamp.org> References: <170661605561.6823.12101770977814458206@vcs2.savannah.gnu.org> <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org> <871q9yonl8.fsf@localhost> <87jznqve8g.fsf@localhost> <878r46v5dp.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23996"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:Q5XFGjngQbXeqCBqLFxPSCemzHs= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 31 16:04:32 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVC8e-0005xL-Jh for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Jan 2024 16:04:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVC7p-0006ap-4e; Wed, 31 Jan 2024 10:03:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVBwQ-0001Gz-7L for emacs-devel@gnu.org; Wed, 31 Jan 2024 09:51:54 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVBwO-0000sw-3V for emacs-devel@gnu.org; Wed, 31 Jan 2024 09:51:53 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rVBwJ-0008sU-Uq for emacs-devel@gnu.org; Wed, 31 Jan 2024 15:51:47 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 31 Jan 2024 10:03:40 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315670 Archived-At: Stefan Monnier wrote: >> Does it mean that you would not recommend moving >> declare-function inside function if that function does not >> have require? > > The `declare-function` tells the compiler "trust me, this > function will exist by the time we reach this point in the > code". > > Often as a programmer, what makes me confident to say such > a thing is that I just did a `require`, but not always [...] If you have a lexical let-closure (a `let' or `let*' at top-level and a `defun' within it) and byte-compile the file, the byte-compiler will warn the function isn't known to be defined it it is refered to in the code. So after the defun one can use `declare-function', either inside the closure or after it. I have mentioned it a couple of times so I know it is well-known, and probably a bug or area of possible improvement in the byte-compiler. -- underground experts united https://dataswamp.org/~incal