From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Iurie Marian <marian.iurie@gmail.com>
Cc: 71709@debbugs.gnu.org
Subject: bug#71709: Fix recent change in tramp-sh-handle-make-process
Date: Sat, 22 Jun 2024 14:02:42 +0200 [thread overview]
Message-ID: <87zfrdp4m5.fsf@gmx.de> (raw)
In-Reply-To: <877cehql8y.fsf@gmx.de> (Michael Albinus's message of "Sat, 22 Jun 2024 13:18:05 +0200")
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Iurie,
> Thanks for the recipe. I've played with it. Most cases, it works as
> expected, but sometimes I see a similar error. Looks like a race
> condition. I'll debug further.
Well, I've found something suspicious in the code. Could you, pls, apply
the appended patch to tramp.el in your Emacs Lisp directory? Since it
changes a macro, you must remove all tramp*.elc files, and run 'make'
afzerwards.
>> Kind Regards,
>> Iurie
Best regards, Michael.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1121 bytes --]
diff --git a/lisp/tramp.el b/lisp/tramp.el
index d9db17ea..f97ed66c 100644
--- a/lisp/tramp.el
+++ b/lisp/tramp.el
@@ -3594,8 +3594,7 @@ that a stederr file is supported. BODY is the backend specific code."
(not (tramp-equal-remote default-directory stderr)))
(signal 'file-error (list "Wrong stderr" stderr)))
- (let ((default-directory tramp-compat-temporary-file-directory)
- (name (tramp-get-unique-process-name name))
+ (let ((name (tramp-get-unique-process-name name))
(buffer
(if buffer
(get-buffer-create buffer)
@@ -5058,7 +5057,8 @@ should be set connection-local.")
;; Check for `tramp-sh-file-name-handler' and
;; `adb-file-name-handler-p', because something is different
;; between tramp-sh.el, and tramp-adb.el or tramp-sshfs.el.
- (let* ((sh-file-name-handler-p (tramp-sh-file-name-handler-p v))
+ (let* ((default-directory tramp-compat-temporary-file-directory)
+ (sh-file-name-handler-p (tramp-sh-file-name-handler-p v))
(adb-file-name-handler-p (tramp-adb-file-name-p v))
(env (mapcar
(lambda (elt)
next prev parent reply other threads:[~2024-06-22 12:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 18:12 bug#71709: Fix recent change in tramp-sh-handle-make-process Iurie Marian
2024-06-21 19:21 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-21 21:09 ` Iurie Marian
2024-06-22 7:31 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-22 9:10 ` Iurie Marian
2024-06-22 9:18 ` Iurie Marian
2024-06-22 9:23 ` Iurie Marian
2024-06-22 11:18 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-22 12:02 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-06-22 16:52 ` Iurie Marian
2024-06-22 17:05 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-22 17:27 ` Iurie Marian
2024-06-22 17:54 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfrdp4m5.fsf@gmx.de \
--to=bug-gnu-emacs@gnu.org \
--cc=71709@debbugs.gnu.org \
--cc=marian.iurie@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.