From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 73412-done@debbugs.gnu.org
Subject: bug#73412: 31.0.50; Improve sql-read-product
Date: Sat, 21 Sep 2024 22:29:54 +0200 [thread overview]
Message-ID: <87zfo0n41p.fsf@gmx.net> (raw)
In-Reply-To: <86o74h2fts.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 21 Sep 2024 18:21:03 +0300")
On Sat, 21 Sep 2024 18:21:03 +0300 Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Sat, 21 Sep 2024 16:32:16 +0200
>> From: Stephen Berman via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> 0. emacs -Q
>> 1. C-u M-x sql-product-interactive RET
>>
>> Now the minbuffer displays the following:
>>
>> SQL product: ansi
>>
>> so it you want to change the product, e.g. to postgres, you first have
>> to delete "ansi".
>>
>> Likewise, `M-x sql-set-product RET' produces the same minbuffer display,
>> requiring deletion to change the product.
>>
>> The reason "ansi" is displayed after the prompt is that the definition
>> of sql-read-product uses the same non-nil value of the deprecated
>> argument INITIAL-INPUT as is used for the argument DEF. The attached
>> patch makes INITIAL-INPUT nil, thus using only DEF, and also wraps the
>> prompt argument of sql-read-product in format-prompt, so the default
>> value is shown as part of the prompt and changing it does not require
>> deletion. The patch also adjusts the two callers of sql-read-product
>> accordingly.
>
> Thanks.
>
> I think this should go to the emacs-30 branch, no?
I agree and did so in commit c1f2501f55d and am closing the bug. Since
this is a minor UI update and improvement with no change in
functionality I assume it does not need to be called out in NEWS, right?
Steve Berman
next prev parent reply other threads:[~2024-09-21 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 14:32 bug#73412: 31.0.50; Improve sql-read-product Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-21 15:21 ` Eli Zaretskii
2024-09-21 20:29 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-09-21 23:51 ` Stefan Kangas
2024-09-22 4:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfo0n41p.fsf@gmx.net \
--to=bug-gnu-emacs@gnu.org \
--cc=73412-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.