From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#64055: [WIP Patch] Enable editing commit messages - vc-git-modify-change-comment Date: Fri, 18 Oct 2024 17:30:16 +0800 Message-ID: <87zfn1vjvb.fsf@melete.silentflame.com> References: <87pm5yo4m7.fsf@gmail.com> <87legmnq4l.fsf@gmail.com> <87r090o8cl.fsf@melete.silentflame.com> <874j5vgypf.fsf@melete.silentflame.com> <787fb692-db24-4682-871b-5a52d31a1249@gutov.dev> <87ed4obs1b.fsf@melete.silentflame.com> <87o73sad24.fsf@melete.silentflame.com> <877ca63ln5.fsf@melete.silentflame.com> <86r08enfri.fsf@gnu.org> <87cyjyvsns.fsf@melete.silentflame.com> <868qulojrx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40550"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Morgan.J.Smith@outlook.com, rpluim@gmail.com, 64055@debbugs.gnu.org, dmitry@gutov.dev To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 18 11:31:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t1jJz-000AH8-06 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Oct 2024 11:30:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1jJj-00087W-Q3; Fri, 18 Oct 2024 05:30:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1jJh-00087D-1g for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 05:30:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1jJg-0000Ug-BT for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 05:30:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=0MOJXU5CUEAEtRgMiHriBKDllyoxJL99O8vOJET+9rU=; b=FIeb+vo90O9Q6XKJe1saj3bJjlCFNu8Be08/JfCw5WmRf1GA/tLCfIceygG0O5jM7/AzGDzyd+sAm/d3+aUdLGK2VUYewM708ogBmPpWD2uq8H/K02tja3N+qFRQvwSa3tmucQqILCaH+vEOcP/wX5NpxSLnQspHH6Yv7+O/aCxAlOqntP1G3KdL74NgPoXM1Bu/fJcAuNv8d8NZUYctJIwPWy2NGoqCmLrVVMDj4iW0qAh1dRXF3GosaBQz5rgXwa1QChp21kL+y+hZhyML1usPMD6xApJc8syS60hsun4k6L7+TIjEuc0cxHXmqQcMUevcbSPTvuT7P9T+AFYABw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1jK2-0005NM-5W for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 05:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Oct 2024 09:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.172924385020644 (code B ref 64055); Fri, 18 Oct 2024 09:31:02 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 18 Oct 2024 09:30:50 +0000 Original-Received: from localhost ([127.0.0.1]:37100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1jJp-0005Mt-LL for submit@debbugs.gnu.org; Fri, 18 Oct 2024 05:30:50 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:34426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1jJn-0005Mc-Rd for 64055@debbugs.gnu.org; Fri, 18 Oct 2024 05:30:48 -0400 DKIM-Signature: a=rsa-sha256; b=R0Jw82y9cskQAw2KUNU0BoyuHGj4FGicG+/KvsEdb2sazaHPbCD55SQo26N9ytelTIQR645riv7QgcSgiyd9Skf5L7D1R400BXEwr6g7CIWtwL0g3O3sw+l6/nhNLGY2LbBS2tifEbBF18Wrc8MXOZvJO3TXO1wsACxp9Lm0Oq0BNoqwdDuWJmXoVRI5GHn4taCJymxhg/kTjrM8oXx9z8niuOi5OInso1nteqoWuxsl6fe5z+ijkNJri5I8/oeK2BDIYLbhLdD+v/Iqtt2MIac7ujPoUoOmX+Fphln/FIBxab6LA5TckX5szLYzxPFgGDD4xtQzVdY6gADVIkRRpg==; s=purelymail1; d=spwhitton.name; v=1; bh=2H9Hpg5lLEZV/DUAH3CjPRyfPwRWcWNli4TPwiBSH98=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=dyPJFoTvWq3tnZ0IfTzEloERPe9iL6ppkcAAVXnRV82Goml5bTidTXb4E8plz39sCGCju5zvXge0z0sWdBTjR5mNQJ0qQQnBs8KBhcXpbMp9q540GcTJQqanVVvNc2q+Z3sUSWyj3wQz09V8Bq4XEU0ASP3VASKJvDxKu8cFW6ytKn8g7+6W0DlVc4KzDYeon76V63OQgBkcTsT9i9rUUD+Va1h7YC1GuQdWGxjNlv3wQT9v6GgUsdqhTeNvvzRzNLv797yqhyN442HXeKb7L5LZLjYSuTQFMoxHB2qbFldZeg0bDM9y4zmngNIMC8sODf7UYnPvS6O7/X+/yxphPA==; s=purelymail1; d=purelymail.com; v=1; bh=2H9Hpg5lLEZV/DUAH3CjPRyfPwRWcWNli4TPwiBSH98=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 64055@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1873330782; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 18 Oct 2024 09:30:18 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 5B7177E980F; Fri, 18 Oct 2024 17:30:16 +0800 (CST) In-Reply-To: <868qulojrx.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Oct 2024 12:14:10 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293777 Archived-At: Hello, On Fri 18 Oct 2024 at 12:14pm +03, Eli Zaretskii wrote: > Definitely. It is otherwise very hard to realize that the discussion > of these changes happened in this particular bug. Right, okay. > That's definitely not what the comments and the implementation convey. > And I then understand even less why the backend action was added for > Git in the first place. Hmm, I see what you mean. I should have included more detail in the commit message and/or comments. >> > Btw, since CVS has an existing command-line option to amend the log >> > message of a particular commit, I wonder whether the design that goes >> > through a separate backend function which extracts the comment first >> > is valid. >> >> We still need to extract the comment first so that the user has some >> text to edit. > > Are we envisioning the user invoking this from anything other than a > log buffer? Why would someone want to do that? I can imagine a few cases where it might be useful, but I don't think that's the main point. The main point is that parsing text out of the log view buffer is much more error-prone. For example, with a non-distributed VCS like CVS, what if someone else has edited the comment in the meantime? It makes sense to fetch the latest known version instead of relying on buffer text. So, I hope that we will eventually completely replace log-view-extract-comment. -- Sean Whitton