From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl Newsgroups: gmane.emacs.bugs Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Date: Thu, 07 Nov 2024 09:04:42 -0600 Message-ID: <87zfmbozjp.fsf@pub.pink> References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22685"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.1; emacs 31.0.50 Cc: 74235@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 07 16:05:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t944i-0005ed-9x for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Nov 2024 16:05:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t944M-0004UP-6C; Thu, 07 Nov 2024 10:05:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t944F-0004TW-O3 for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2024 10:05:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t944F-0005kK-FI for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2024 10:05:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=9hR++o5VjIOiYawdbMpnvpDL33hRvkroHXBPsRtn2gg=; b=kui3xFAbIkJFwMRKH43B+CoULMGD6nS7gOY8tt+ync3d3nQ0mGeBj2fdiNz0F/hOiI0MEUw3COHlRTFnL69EeOsJN9L22PN775ML/b1Og7D6EDTx5r31S9kTAogZpXgfkRrDGnCjCNCQ6ob6ArlFRJqJPgpAZ6Pl9VVIUlocYKYyFAOyLPh6BnZKva4ksk1rUt4Lq4pvK0BI6Hh4SGysPKdNOc6FezZRBBpytijgqa63bRFbP11BUXcee+b+Pgr1BvuuAQ95PXH1CRhLnL52YhgWO1RX95TGDOvJUvLflq4cgVCibJxgu0CpUHlhWS7ZHNQ/RzNXydozMqojdYUUEQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t944F-0003tq-0y for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2024 10:05:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Nov 2024 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74235-submit@debbugs.gnu.org id=B74235.173099189214963 (code B ref 74235); Thu, 07 Nov 2024 15:05:02 +0000 Original-Received: (at 74235) by debbugs.gnu.org; 7 Nov 2024 15:04:52 +0000 Original-Received: from localhost ([127.0.0.1]:49227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9443-0003tG-OK for submit@debbugs.gnu.org; Thu, 07 Nov 2024 10:04:52 -0500 Original-Received: from fhigh-b7-smtp.messagingengine.com ([202.12.124.158]:48501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9441-0003sx-V2 for 74235@debbugs.gnu.org; Thu, 07 Nov 2024 10:04:50 -0500 Original-Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfhigh.stl.internal (Postfix) with ESMTP id 6BC0F254009B; Thu, 7 Nov 2024 10:04:44 -0500 (EST) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Thu, 07 Nov 2024 10:04:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1730991884; x=1731078284; bh=9hR++o5VjIOiYawdbMpnvpDL33hRvkroHXBPsRtn2gg=; b= YKgeZRwEXwEVjW5Sy6VZwaxJGqNNv2NkvisEpzcIzD3k+REqy9uCZzmTcUr4ujmG VKleQ8XpMZy9bLdCi0ZcdJV7LfK35fzXYORusgzRi6SseGgF5P+mzKBqxQkkGeDj uJheXoTlukj1uqlFothvMiZPo5RLaBbNrj3/WY1vbHQgW/skPzPvB62NNpSwhjRO VZhMlfTcbmtDrHnfXo/rE/flzyoCc7kGguS3yrd/bTki5+23uMuj5IDw5pSL2Kfc 8ZM+PEvXazB6OjztLzusAlBSQdeeLPpYNIker327WJOmfvKTPNE1mIkuRJ+t73V3 p1vHs/vEJ1gF4PLgQLGxrg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1730991884; x= 1731078284; bh=9hR++o5VjIOiYawdbMpnvpDL33hRvkroHXBPsRtn2gg=; b=U A6sucENPZJzkucBQ8q2vi3S9QOSHlbzKpI/6om10C2WW3ZtNqPQB7+dMp94fFU8J MphFVZ6IqFd/SC8ACCsyT6f3vngJZQZGLV8iGcqwL7WECbO0HSvJrAle6lNdbTN/ brkfdZkLYWCeTbd9IsbuZeNaQEQmQ2lbtjnWn8okF8uFM4du9+nLE5S0Kz3h+hhk IlV4wjiSbe3dMzF1gzV5gaFiqTow0GPLLtYrbgl8L7+n5nUkHm2RQEscYBYLKaiR 3Gfb8uUbp9UIBTLYiYjN6uF/USX3jW7B10QKpib9ykENe0jPwprtsywZyDdua0t/ o7f/TO8w7sJuXHcVXJn5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtdeggdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeen ucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhusgdrphhinhhkqeenucggtffrrg htthgvrhhnpeegveehvddttedvkeduvddttdehhfdvgffgvdfgiedtjeduhefhffejtddv veevkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hjmhesphhusgdrphhinhhkpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopeejgedvfeehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpth htohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Nov 2024 10:04:43 -0500 (EST) In-Reply-To: <86y11vr3e5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Nov 2024 07:58:42 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295027 Archived-At: Eli Zaretskii writes: >> From: john muhl >> Date: Wed, 06 Nov 2024 15:22:34 -0600 >>=20 >> * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): >> (lua-ts-inferior-program): Remove 'nil' as it is never a valid >> choice. (Bug#74235) > > IMO, the use of these options in the code is not clean: if these > programs are not installed, the commands which reference these options > will signal errors whose diagnostic might not clearly indicate the > root cause. I would like to see a cleaner handling of such > contingencies by this mode. Does this make sense, and if so, would > you like to suggest changes to that effect? Good point. I=E2=80=99ll work on that very soon. >> (defcustom lua-ts-luacheck-program "luacheck" >> "Location of the Luacheck program." >> - :type '(choice (const :tag "None" nil) string) >> + :type 'string >> :version "30.1") > > I think if we require this to be the name of a program, 'file' is a > better value for :type, because it allows completion if the user types > an absolute file name. Makes sense. >> (defcustom lua-ts-inferior-buffer "*Lua*" >> @@ -83,7 +83,7 @@ lua-ts-inferior-buffer >>=20=20 >> (defcustom lua-ts-inferior-program "lua" >> "Program to run in the inferior Lua process." >> - :type '(choice (const :tag "None" nil) string) >> + :type 'string >> :version "30.1") >>=20=20 >> (defcustom lua-ts-inferior-options '("-i") >> --=20 >> 2.47.0 >>=20 >> john muhl writes: >>=20 >> > Tags: patch >> > >> > For some silly reason the lua-ts-{inferior,luacheck}-program >> > options ended up with an option for =E2=80=9CNone=E2=80=9D. Obviously = setting your >> > Lua interpreter or linter program to nil is not going to work. >> > >> > Any chance it could make it into emacs-30? > > lua-ts-mode is new in Emacs 30, so we can install these changes on the > release branch, as a stopgap. But I'd like to see a cleaner solution > installed later, even if we decide to install that on master due to > its complexity. > > Thanks. Then let=E2=80=99s put this one on hold and I=E2=80=99ll work on the improv= ements you suggest. Hopefully it doesn=E2=80=99t require significant changes and we can skip the stopgap and get it all into 30. Thanks for the help.