all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bruno Boal <egomet@bboal.com>
To: 74363@debbugs.gnu.org
Subject: bug#74363: [PATCH] Type correction and docstring change in `erc-spelling-dictionaries'
Date: Fri, 15 Nov 2024 01:22:56 +0000	[thread overview]
Message-ID: <87zfm1b89b.fsf@bboal.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

Tags: patch


Salutations,

This patch addresses a minor incorrection in the :type of the variable
`erc-spelling-dictionaries' in the erc-spelling library.
The :group keyword is also dropped, as it inherits from the
defgroup declared earlier in the file.

Additionally, a change to the docstring is proposed to better adhere to
the examples and explanations of the manual.

Note that the initial form of :type was preserved for clarity instead of
the alternative option: (alist :value-type (group string))

Best regards



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Type-correction-and-docstring-change-in-erc-spelling.patch --]
[-- Type: text/patch, Size: 1514 bytes --]

From ae9fef20af624c885e3da3583326a2546057e7ce Mon Sep 17 00:00:00 2001
From: Bruno Boal <egomet@bboal.com>
Date: Thu, 14 Nov 2024 23:58:43 +0000
Subject: [PATCH] Type correction and docstring change in
 `erc-spelling-dictionaries'

---
 lisp/erc/erc-spelling.el | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/lisp/erc/erc-spelling.el b/lisp/erc/erc-spelling.el
index b2f565d71bf..558cef2d2b2 100644
--- a/lisp/erc/erc-spelling.el
+++ b/lisp/erc/erc-spelling.el
@@ -52,15 +52,17 @@ (define-erc-module spelling nil
 
 (defcustom erc-spelling-dictionaries nil
   "An alist mapping buffer names to dictionaries.
-The `car' of every cell is a buffer name, the `cadr' is the
-string name of an associated dictionary.
+
+Each element is a list of strings with the form (KEY VALUE) where KEY
+is a buffer name and VALUE, the name of the dictionary to be
+associated.
+
 The dictionary is inherited from server buffers, so if you want a
-default dictionary for some server, you can use a server buffer
-name here."
+default dictionary for some server, you can use a server buffer name
+here."
   :type '(choice (const nil)
-                 (repeat (cons (string :tag "Buffer name")
-                               (string :tag "Dictionary"))))
-  :group 'erc-spelling)
+                 (repeat (list (string :tag "Buffer name")
+                               (string :tag "Dictionary")))))
 
 (defun erc-spelling-init (buffer)
   "Enable flyspell mode in an ERC buffer.
-- 
2.47.0


[-- Attachment #3: Type: text/plain, Size: 75 bytes --]


-- 
Bruno Boal
GPG Key: 7DCD 57C5 CF25 EE42 A561 3382 74AE 782E 08F0 E5A8

             reply	other threads:[~2024-11-15  1:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-15  1:22 Bruno Boal [this message]
2024-11-15 20:03 ` bug#74363: [PATCH] Type correction and docstring change in `erc-spelling-dictionaries' J.P.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfm1b89b.fsf@bboal.com \
    --to=egomet@bboal.com \
    --cc=74363@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.