[வியாழன் டிசம்பர் 05, 2024] Eli Zaretskii wrote: >> From: Visuwesh >> Date: Thu, 05 Dec 2024 11:42:08 +0530 >> >> Attached patch makes it possible to revert the current Dired buffer by >> clicking on the last segment of the directory line. With the patch >> applied, >> >> /home/viz/lib/ports/emacs: >> >> clicking on 'emacs' now reverts the buffer that shows ~/lib/ports/emacs. >> Previously, it did nothing. This makes it possible to update the Dired >> listing without needing to use the keyboard. > > Thanks, a few comments below. > >> +--- >> +*** Clicking on last segment of directory reverts buffer >> +When 'dired-make-directory-clickable' is non-nil, clicking on the last >> +segment of the directory name now reverts the Dired buffer. > > We don't call these "segments", we call them "components". And since > you are talking about the last one, you could also say "base name of > the directory". I've changed it to base name. >> + (when (search-forward ":" bound t) >> + (add-text-properties >> + segment-start (1- (point)) >> + `( mouse-face highlight > ^^ > We don't leave whitespace after the opening parenthesis. I removed the whitespace. But isn't that way to make lists such as ( 1 2 3) aligned without manual intervention? It is used in the list above too. >> + help-echo "mouse-1: revert this buffer" > > I think the help-echo should say something more similar to what we say > for the other components of the directory shown in the header line. > Something like "re-read this buffer's directory". Now done. >> + keymap ,(define-keymap >> + "" #'revert-buffer >> + "" 'follow-link >> + "RET" #'revert-buffer)))))))) > > Should we perhaps call dired-revert directly? revert-buffer-function is set to dired-revert by dired. If someone has changed it, for some reason, using revert-buffer would heed their customisation. So I've left it as revert-buffer.