From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Date: Mon, 30 Dec 2024 00:34:22 +0100 Message-ID: <87zfkevzb5.fsf@web.de> References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <875xn3jm1x.fsf@web.de> <86jzbjq8a8.fsf@gnu.org> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14978"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: sunlin7@hotmail.com, 74881@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 30 00:34:35 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tS2np-0003lL-Kv for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Dec 2024 00:34:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tS2nT-0002XD-GV; Sun, 29 Dec 2024 18:34:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tS2nL-0002Wx-UK for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2024 18:34:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tS2nK-0000qa-Tl for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2024 18:34:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=38+VSkw76FMUR+0SA1rUc+xN0FjokHvzNOlZXraH1tY=; b=Fv3tJWPj3MIvqYSIcR9W7TKmvOUUXWxgz/EMZo5NnXaX9i8GwPhpQcCMrLvuvSLNZtE5InHHip1rb1D5jDkwpS5IztkUcTnZcQuZvcLcdQXKAaGMDNDf59paegrVo5SMJHSMfCyqhrMjQ+9gxwrLpduFr91PtppNktKbMz2iQ5mRaNiAl1BgIx1oshChL9hAMDGp2X/Yv1nNdyHJPjbQz6xDiDfzRfwJsD3hqsZgz+Oq7FHjSu6XRFHRnZ/Q4cJ+l5qRRX2l9E9Xo8VQd8EoztOGIXqq2nD3S7QLWNJYRm7D75T4WQsS7RvaNZeYsOCejcraDH8x1XH51zcMaGriZA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tS2nJ-0003ic-RC for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2024 18:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Dec 2024 23:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74881 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74881-submit@debbugs.gnu.org id=B74881.173551520814247 (code B ref 74881); Sun, 29 Dec 2024 23:34:01 +0000 Original-Received: (at 74881) by debbugs.gnu.org; 29 Dec 2024 23:33:28 +0000 Original-Received: from localhost ([127.0.0.1]:56565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tS2mm-0003hj-DV for submit@debbugs.gnu.org; Sun, 29 Dec 2024 18:33:28 -0500 Original-Received: from mout.web.de ([217.72.192.78]:47501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tS2mk-0003hV-D1 for 74881@debbugs.gnu.org; Sun, 29 Dec 2024 18:33:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1735515193; x=1736119993; i=michael_heerdegen@web.de; bh=38+VSkw76FMUR+0SA1rUc+xN0FjokHvzNOlZXraH1tY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=ROONbBeUNKvsKils8vxEIIjurpxrE2InCZXAN4a5NtjUml+PCX67zpxXau2JGSw8 CCbD9maxIXcTLQ4WB7Z3yr47gajl3h+TGab1kCvrsB5RyLZ7307BVkqmy4JdAeqN+ 55kB71MSO/FGkqdWBgKnPO9ExeqS6/33BbP5BVAR7exstGSM3J/w/9bbMG+qW3Uw1 Z4m8J6DTCCASmFmCASg/HI1hcvEBcvCXj0DhNPVSIlLKhcfmj5OCrZj3ClH+v9PJ5 WfF5cCsPl39c3ODgvhd+B6NbNA8DaAp8XGonxXtSTVjLa1L2qyJvQzTdDiYMAc6PF 0m1D1F40+2VYsxzF1w== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([92.75.138.197]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MCXVZ-1tJYaY23oB-00FawS; Mon, 30 Dec 2024 00:33:13 +0100 In-Reply-To: <86jzbjq8a8.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Dec 2024 09:04:47 +0200") X-Provags-ID: V03:K1:6CUcQraqU9rAkyB4eC9CJMeSFW5PqMqHZg585XqTmD9n66FoZmF 3PL5A8nyCI12dXNKc/SAe8pob8Xa4XF3XhDAU+K63cdLn7ozuZ6yFdYyxQUwYMS4L/BVLvD Oby/cYgUsIpiXGjKN2XO/ukkaZ2Jmo6iKg5DdN2wEYJ447pU1gVgaUUBytEqmtakf8HQV6q ZtwZJG1uGWo26479CiOxA== UI-OutboundReport: notjunk:1;M01:P0:+N7544LpjCk=;RvnamCoRODXJgzaekKoYNS5OgfW 8LP7ABDBIWbAGXUSTnvWqkC69M2e+LlpqSmgQrr+PIQVgG7/93kT4asyWISocnq7jV81q/Pc6 GhcfcmwgQlLxcY+tV5qHwpQLzw5TwTLbfViIh+OLVIKseor7zbjIr7oc8gGmCywQTUVflWYJy fW/256PdLjA9onEs+iXPDAM8PPBpVnU56Cn2LPGktS79k5FjVd26xSycY7N353diSyUZgvHYy fbMYEr9TCl/XG3Tx0fTQR0QaCnVz62Z+lpnSG07v1UikF5zI+4w2NUZyTNwzPN1BjZenCfhhm mlKTPE6Fmgt6VtL2IObDoE8dvxTLs9lGAOtUEzbYMbn5idOo5tMUCApWwL4PcqMMpehwv+14R 1e+HyOAoiq8z2iimLrz5gcRzmqfICyIjo60mkfVzUgaqiGrYFyj3IECu+cKTLCyhm+arCWmq2 M6rVXysdb9coJg46yKVXXcz/UoaPQQyoyFKoNV6vKEvlAWr+yfOO9yQtxBnYY8EwdGm05rD8c beZ4jr/gsAB+JGJnU/eo8Oe30RtPG5CG44DAAZeCC0D2znFLPDgStsQMjIitnQ3i5k2mwhnid Yp6z6Wj9a50w2AinRhnoRwY9IkM6TKqPqI1XON50+3J0EKZdd5Peo7tPtteCl9dycJDIXRTGg tizdG723duogR2UwZsnCHTwHDyCWRppP0arUqwamClE5H4vG/gdAF6T5oZRyUmtok5hTsgbvw Qhb+SdzFDPQl0fRqeFeUqRUQm7zSYD2Gd3PxgyOgR84goEclPtriece135NT4uHHDai+Bv+W X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297977 Archived-At: Eli Zaretskii writes: > > > @@ -488,6 +496,7 @@ ediff-setup > > > (if (ediff-buffer-live-p ediff-meta-buffer) > > > (ediff-update-meta-buffer > > > ediff-meta-buffer nil ediff-meta-session-number)) > > > + (add-hook 'kill-emacs-hook #'ediff--delete-temp-files-on-kill= -emacs) > > > > Would it be ok to avoid the above loop completely by using the buffer > > local version of `kill-emacs-hook' instead? > > You assume that the temporary Ediff files are always visited in some > buffer? Is that assumption true? I think you misunderstood: my idea was to put `ediff-delete-temp-files' to the local hook binding of the ediff control buffers (which we currently consult anyway). This would result in the same calls as now - at least when local `kill-emacs-hook' bindings worked. Michael.