* eshell multiple output targets fix
@ 2002-10-22 7:53 Bob Halley
2002-10-22 17:56 ` John Wiegley
0 siblings, 1 reply; 4+ messages in thread
From: Bob Halley @ 2002-10-22 7:53 UTC (permalink / raw)
Cc: emacs-devel
The Eshell documentation says that Eshell can write to multiple output
targets, e.g.
(+ 1 2) > a > b > c ; prints number to all three files
When I have tried this, it has not worked; the last redirect target
was the only file written.
Making the following change to esh-io.el fixed things. Basically the
problem was that the value stored in 'current' was not a list, so the
(and (listp current) (not member where current)) appending logic never
ran.
/Bob
Index: esh-io.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/eshell/esh-io.el,v
retrieving revision 1.6
diff -u -r1.6 esh-io.el
--- esh-io.el 16 Feb 2002 09:42:53 -0000 1.6
+++ esh-io.el 22 Oct 2002 07:47:14 -0000
@@ -396,7 +396,7 @@
(if (and (listp current)
(not (member where current)))
(setq current (append current (list where)))
- (setq current where))
+ (setq current (list where)))
(if (not (aref eshell-current-handles index))
(aset eshell-current-handles index (cons nil 1)))
(setcar (aref eshell-current-handles index) current)))))
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: eshell multiple output targets fix
2002-10-22 7:53 eshell multiple output targets fix Bob Halley
@ 2002-10-22 17:56 ` John Wiegley
2002-10-22 18:10 ` Bob Halley
0 siblings, 1 reply; 4+ messages in thread
From: John Wiegley @ 2002-10-22 17:56 UTC (permalink / raw)
>>>>> On Tue Oct 22, Bob writes:
> Making the following change to esh-io.el fixed things. Basically
> the problem was that the value stored in 'current' was not a list,
> so the (and (listp current) (not member where current)) appending
> logic never ran.
As long as you've tested it with single redirection, piping, and no
redirection, feel free to check it in. Thanks, Bob!
John
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: eshell multiple output targets fix
2002-10-22 17:56 ` John Wiegley
@ 2002-10-22 18:10 ` Bob Halley
2002-10-22 18:22 ` John Wiegley
0 siblings, 1 reply; 4+ messages in thread
From: Bob Halley @ 2002-10-22 18:10 UTC (permalink / raw)
Cc: emacs-devel
John Wiegley <johnw@gnu.org> writes:
> >>>>> On Tue Oct 22, Bob writes:
>
> > Making the following change to esh-io.el fixed things. Basically
> > the problem was that the value stored in 'current' was not a list,
> > so the (and (listp current) (not member where current)) appending
> > logic never ran.
>
> As long as you've tested it with single redirection, piping, and no
> redirection, feel free to check it in. Thanks, Bob!
I tested single redirection, multiple redirection, combining redirection
and piping, and no redirections. All worked.
I am not an official Emacs developer, so I cannot commit the fix. :)
/Bob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: eshell multiple output targets fix
2002-10-22 18:10 ` Bob Halley
@ 2002-10-22 18:22 ` John Wiegley
0 siblings, 0 replies; 4+ messages in thread
From: John Wiegley @ 2002-10-22 18:22 UTC (permalink / raw)
>>>>> On Tue Oct 22, Bob writes:
> I am not an official Emacs developer, so I cannot commit the
> fix. :)
Ok, I have checked it in with you as the developer.
John
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-10-22 18:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-10-22 7:53 eshell multiple output targets fix Bob Halley
2002-10-22 17:56 ` John Wiegley
2002-10-22 18:10 ` Bob Halley
2002-10-22 18:22 ` John Wiegley
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.