all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
Cc: romain@orebokech.com, emacs-devel@gnu.org
Subject: Re: mouse-1-click-follows-link and mime messages
Date: Wed, 08 Feb 2006 15:51:19 -0500	[thread overview]
Message-ID: <87y80lo9q0.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1F6ucg-0003if-OX@fencepost.gnu.org> (Richard M. Stallman's message of "Wed, 08 Feb 2006 14:05:02 -0500")

"Richard M. Stallman" <rms@gnu.org> writes:

>     > 	* mouse.el (mouse-drag-region-1): When remapping mouse-1 to
>     > 	mouse-2, go back to previously selected window, so it's selected
>     > 	when mouse-2 command runs.
>
>     Looks like this affects all `link' widgets.  For instance, clicking on
>     the links in the Customize buffer does not work if another window is
>     selected.
>
> The change I made is correct in principle.  When the mouse-2 command
> finally gets run, the selected window should not have been altered by
> the translation mechanism.  The event says which window was clicked
> on.  The selected window should be the one that was selected by the
> user.
>
> It sounds like the command that handles mouse-2 on a link needs fixing.

I figured out the problem.  We should only change the selected window
if we are translating to mouse-2.  The `follow-link' property can also
specify translation to, e.g., "\C-m" (in the case of the link widget);
in that case, we shouldn't change the window.

I've checked in a fix.

  reply	other threads:[~2006-02-08 20:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-06 20:43 mouse-1-click-follows-link and mime messages Chong Yidong
2006-02-07  7:44 ` Romain Francoise
2006-02-07 17:26   ` Chong Yidong
2006-02-07 18:05     ` Romain Francoise
2006-02-07 19:43       ` Chong Yidong
2006-02-07 23:29   ` Chong Yidong
2006-02-08  0:42     ` Chong Yidong
2006-02-09 17:48       ` Richard M. Stallman
2006-02-08 19:05     ` Richard M. Stallman
2006-02-08 20:51       ` Chong Yidong [this message]
2006-02-10  1:12         ` Richard M. Stallman
2006-02-10  1:32           ` David Kastrup
2006-02-16 14:32         ` mouse-1 drag invokes follow-link (was: mouse-1-click-follows-link and mime messages) Reiner Steib
2006-02-16 16:04           ` mouse-1 drag invokes follow-link Chong Yidong
2006-02-16 21:12             ` Reiner Steib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y80lo9q0.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=romain@orebokech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.