From: Michael Cadilhac <michael.cadilhac@lrde.org>
Subject: Re: [emacs-pretest-bug] Re: C indentation error.
Date: Mon, 27 Mar 2006 20:13:37 +0200 [thread overview]
Message-ID: <87y7yvn4by.fsf@mahaena.lrde> (raw)
In-Reply-To: <87irq7ll31.fsf@mahaena.lrde> (Michael Cadilhac's message of "Tue, 21 Mar 2006 19:16:34 +0100")
[-- Attachment #1.1: Type: text/plain, Size: 3111 bytes --]
Haven't seen any comments for this and my boss complains about his
<tab> key issuing errors when working on my files ;-)
Thanks in advance !
Michael Cadilhac <michael.cadilhac@lrde.org> writes:
> Richard Stallman <rms@gnu.org> writes:
>
>> > I got an error with some C indentation in macro definitions in GNU
>> > Emacs 22.0.50.34 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of
>> > 2006-03-02.
>> >
>> > Error is triggered by:
>> >
>> > With emacs -Q :
>> > In scratch, insert the following:
>> >
>> > #foo :\
>> > bar
>> >
>> > Toggle to c-mode, and try to indent the last line.
>> >
>> > I get: Invalid search bound (wrong side of point).
>>
>> However, looking at the code of search_command, I'm wondering why
>> an error could be output even if noerror is t or a symbol [1] ;
>> fixing this that way :
>>
>> The noerror argument means "no error if the search fails".
>> Invalid arguments are a different issue.
>>
>> I will clarify this in the Lisp manual.
>>
>> So your proposed change in search.c should not be installed.
>
> That's what I thought ; I was trying to get a reaction for this bug
> report ;-)
>
>> Instead, the code in CC mode should be fixed not to pass invalid
>> search bounds.
>
> After a little more search, I propose the following change :
>
> Index: lisp/progmodes/cc-engine.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/progmodes/cc-engine.el,v
> retrieving revision 1.47
> diff -c -r1.47 cc-engine.el
> *** lisp/progmodes/cc-engine.el 24 Feb 2006 15:33:02 -0000 1.47
> --- lisp/progmodes/cc-engine.el 19 Mar 2006 17:59:56 -0000
> ***************
> *** 5916,5922 ****
> ;; it shouldn't apply when we check the
> ;; preceding label.
> c-record-type-identifiers)
> ! (c-forward-syntactic-ws)
> (c-forward-label nil pte start))))))))
>
> ;; Check that the next nonsymbol token is ":". Allow '('
> --- 5916,5922 ----
> ;; it shouldn't apply when we check the
> ;; preceding label.
> c-record-type-identifiers)
> ! (c-forward-syntactic-ws pte)
> (c-forward-label nil pte start))))))))
>
> ;; Check that the next nonsymbol token is ":". Allow '('
>
> ----------------------------------------------------------------------
>
> Well... It fixes the bug, really, but it doesn't investigate the bug
> as it probably should be ; the bug _may_ be in c-forward-sws, a too
> long function for me to work on ;-)
>
> Bye !
--
Michael Cadilhac, a.k.a. Micha [mika] |
Epita/LRDE promo 2007 | )\._.,--....,'``.
123 av. de Fontainebleau | 08.70.65.13.14 | /. _.. \ _\ (` ._,.
94270 Le Kremlin Bicetre | 06.23.20.31.30 | '._.-(,_..'--(,_...`-..'
[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2006-03-27 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-21 18:16 [emacs-pretest-bug] Re: C indentation error Michael Cadilhac
2006-03-27 18:13 ` Michael Cadilhac [this message]
2006-03-28 19:33 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y7yvn4by.fsf@mahaena.lrde \
--to=michael.cadilhac@lrde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.