From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Hansen Newsgroups: gmane.emacs.devel Subject: Re: Fwd: pcomplete bug with special display buffers Date: Wed, 07 Mar 2007 16:04:46 +0100 Organization: disorganized Message-ID: <87y7m9hz75.fsf@localhorst.mine.nu> References: <878xec86jk.fsf@localhorst.mine.nu> <874pozlhnq.fsf@stupidchicken.com> <87d53noyvf.fsf@localhorst.mine.nu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1173280182 7182 80.91.229.12 (7 Mar 2007 15:09:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 7 Mar 2007 15:09:42 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 07 16:09:27 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HOxld-00079a-VV for ged-emacs-devel@m.gmane.org; Wed, 07 Mar 2007 16:09:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HOxlj-0002Mg-UN for ged-emacs-devel@m.gmane.org; Wed, 07 Mar 2007 10:09:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HOxlG-0002CM-4c for emacs-devel@gnu.org; Wed, 07 Mar 2007 10:09:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HOxlE-0002BV-MV for emacs-devel@gnu.org; Wed, 07 Mar 2007 10:09:01 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HOxlD-0002BG-TL for emacs-devel@gnu.org; Wed, 07 Mar 2007 10:08:59 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HOxl6-0001Ph-RS for emacs-devel@gnu.org; Wed, 07 Mar 2007 10:08:53 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1HOxkm-0002MQ-1N for emacs-devel@gnu.org; Wed, 07 Mar 2007 16:08:32 +0100 Original-Received: from e178038167.adsl.alicedsl.de ([85.178.38.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 07 Mar 2007 16:08:32 +0100 Original-Received: from david.hansen by e178038167.adsl.alicedsl.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 07 Mar 2007 16:08:32 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 56 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: e178038167.adsl.alicedsl.de Mail-Copies-To: nobody User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.95 (gnu/linux) Cancel-Lock: sha1:8fmROVobDPke1W+HFLKw614Cdf0= X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67506 Archived-At: On Tue, 06 Mar 2007 04:05:24 +0100 David Hansen wrote: > On Mon, 05 Mar 2007 12:33:13 -0500 Chong Yidong wrote: > >> David Hansen writes: >> >>> Hello, >>> >>> is there anything wrong with this one character patch or did it just >>> got lost? >>> >>> I'm using it now for about two weeks and it seems to work pretty >>> well. >> >> Looks good; I checked it in. Thanks. > > Thanks. In the meantime I noticed that the (more or less same) bug > is spread all over the GNU Emacs sources (well, I might exaggerate a > bit). The attached patch is for lisp.el, the same happens at least > in comint.el, I haven't investigated the other results that a grep > showed me. > > The bug in lisp and comint completion won't throw an error as in > pcomplete.el. To reproduce it you have resize the special frame so > that not all possible completions fit within the window. Repeated TAB > key strokes won't scroll the buffer. > Attached the patch for comint.el. Could someone please have a look at `switch-to-completions' in simple.el? My window manager doesn't allow emacs to focus other frames so it won't work for me anyways. Grep indicates that the same bug might be present in org.el, python.el and idlwave.el. I don't use these modes, would be glad if someone else can check these. David Index: lisp/comint.el =================================================================== RCS file: /sources/emacs/emacs/lisp/comint.el,v retrieving revision 1.358 diff -u -r1.358 comint.el --- lisp/comint.el 23 Feb 2007 19:21:25 -0000 1.358 +++ lisp/comint.el 7 Mar 2007 14:58:11 -0000 @@ -2943,7 +2943,7 @@ (defun comint-dynamic-list-completions (completions) "List in help buffer sorted COMPLETIONS. Typing SPC flushes the help buffer." - (let ((window (get-buffer-window "*Completions*"))) + (let ((window (get-buffer-window "*Completions*" t))) (setq completions (sort completions 'string-lessp)) (if (and (eq last-command this-command) window (window-live-p window) (window-buffer window)