From: David Hansen <david.hansen@gmx.net>
To: emacs-devel@gnu.org
Subject: Re: Fwd: pcomplete bug with special display buffers
Date: Wed, 07 Mar 2007 16:04:46 +0100 [thread overview]
Message-ID: <87y7m9hz75.fsf@localhorst.mine.nu> (raw)
In-Reply-To: 87d53noyvf.fsf@localhorst.mine.nu
On Tue, 06 Mar 2007 04:05:24 +0100 David Hansen wrote:
> On Mon, 05 Mar 2007 12:33:13 -0500 Chong Yidong wrote:
>
>> David Hansen <david.hansen@gmx.net> writes:
>>
>>> Hello,
>>>
>>> is there anything wrong with this one character patch or did it just
>>> got lost?
>>>
>>> I'm using it now for about two weeks and it seems to work pretty
>>> well.
>>
>> Looks good; I checked it in. Thanks.
>
> Thanks. In the meantime I noticed that the (more or less same) bug
> is spread all over the GNU Emacs sources (well, I might exaggerate a
> bit). The attached patch is for lisp.el, the same happens at least
> in comint.el, I haven't investigated the other results that a grep
> showed me.
>
> The bug in lisp and comint completion won't throw an error as in
> pcomplete.el. To reproduce it you have resize the special frame so
> that not all possible completions fit within the window. Repeated TAB
> key strokes won't scroll the buffer.
>
Attached the patch for comint.el. Could someone please have a look
at `switch-to-completions' in simple.el? My window manager doesn't
allow emacs to focus other frames so it won't work for me anyways.
Grep indicates that the same bug might be present in org.el,
python.el and idlwave.el. I don't use these modes, would be glad if
someone else can check these.
David
Index: lisp/comint.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/comint.el,v
retrieving revision 1.358
diff -u -r1.358 comint.el
--- lisp/comint.el 23 Feb 2007 19:21:25 -0000 1.358
+++ lisp/comint.el 7 Mar 2007 14:58:11 -0000
@@ -2943,7 +2943,7 @@
(defun comint-dynamic-list-completions (completions)
"List in help buffer sorted COMPLETIONS.
Typing SPC flushes the help buffer."
- (let ((window (get-buffer-window "*Completions*")))
+ (let ((window (get-buffer-window "*Completions*" t)))
(setq completions (sort completions 'string-lessp))
(if (and (eq last-command this-command)
window (window-live-p window) (window-buffer window)
next prev parent reply other threads:[~2007-03-07 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 7:59 Fwd: pcomplete bug with special display buffers David Hansen
2007-03-05 17:33 ` Chong Yidong
2007-03-06 3:05 ` David Hansen
2007-03-06 14:48 ` Stefan Monnier
2007-03-07 15:04 ` David Hansen [this message]
2007-03-07 16:30 ` Stefan Monnier
2007-03-07 16:56 ` David Hansen
2007-03-07 18:12 ` Stefan Monnier
2007-03-05 21:50 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y7m9hz75.fsf@localhorst.mine.nu \
--to=david.hansen@gmx.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.