From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: modification hooks called only once... Date: Fri, 17 Aug 2007 11:22:27 -0400 Message-ID: <87y7ganq30.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1187364436 13309 80.91.229.12 (17 Aug 2007 15:27:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 17 Aug 2007 15:27:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 17 17:27:13 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IM3jC-0008M5-1V for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2007 17:27:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IM3jB-0007fz-CF for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2007 11:27:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IM3j8-0007fS-Mu for emacs-devel@gnu.org; Fri, 17 Aug 2007 11:27:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IM3j6-0007et-AX for emacs-devel@gnu.org; Fri, 17 Aug 2007 11:27:05 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IM3j6-0007eq-5j for emacs-devel@gnu.org; Fri, 17 Aug 2007 11:27:04 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IM3j3-0004pq-0c; Fri, 17 Aug 2007 11:27:01 -0400 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 883254E35D; Fri, 17 Aug 2007 11:22:27 -0400 (EDT) In-Reply-To: (Richard Stallman's message of "Fri\, 17 Aug 2007 00\:50\:12 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-Detected-Kernel: Linux 2.6 (newer, 1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76693 Archived-At: Richard Stallman writes: > Who wrote this in FOR-RELEASE? > > Here we list small fixes that arrived too late for Emacs 22.2, but > that should be installed on the release branch after 22.2 is released. > > ** bojohan+news@dd.chalmers.se, 1 Aug: n_schumacher@web.de: modification hooks called only once in > Fix is on the trunk: 2007-08-13 change to insdel.c by Stefan Monnier. > http://lists.gnu.org/archive/html/emacs-devel/2007-08/msg00457.html > > I am not convinced. Would someone like to argue for this decision? What are you not convinced about: that the fix is correct, or that it has not been put in the branch? If it's the latter, I don't have strong opinions either way. Stefan's fix makes an incompatible change to the behavior of modification hooks, albeit one that makes it behave more cleanly. It seems unlikely that there is existing code that assumes the old behavior, but I don't know for sure. One way to find out is to let it sit in the trunk for a while to see if bugs crop up, but if you think the risk is low, sure, let's add it to the branch now.