Tramp sets LC_ALL to "C"

Tramp sets LC_ALL to "C"

[Romain Francoise]

The following changes are wrong, Tramp should not use `setenv' since
it modifies the global environment and thus affects other packages
which use subprocesses, such as Dired, shell-mode, etc.

2007-10-30  Michael Albinus  <michael.albinus@gmx.de>

	* net/tramp.el (tramp-maybe-open-connection): Set $LC_ALL to "C".

2007-10-31  Michael Albinus  <michael.albinus@gmx.de>

	* net/tramp.el (tramp-open-connection-telnet)
	(tramp-open-connection-rsh, tramp-open-connection-su)
	(tramp-open-connection-multi): Set $LC_ALL to "C".

Re: Tramp sets LC_ALL to "C"

[Michael Albinus]

Romain Francoise <romain@orebokech.com> writes:

Hi Romain,

> The following changes are wrong, Tramp should not use `setenv' since
> it modifies the global environment and thus affects other packages
> which use subprocesses, such as Dired, shell-mode, etc.
>
> 2007-10-30  Michael Albinus  <michael.albinus@gmx.de>
>
> 	* net/tramp.el (tramp-maybe-open-connection): Set $LC_ALL to "C".

Should be OK now, using a local copy of `process-environment'. 

> 2007-10-31  Michael Albinus  <michael.albinus@gmx.de>
>
> 	* net/tramp.el (tramp-open-connection-telnet)
> 	(tramp-open-connection-rsh, tramp-open-connection-su)
> 	(tramp-open-connection-multi): Set $LC_ALL to "C".

That's EMACS_22_BASE. `process-environment' is already let-bound at the
right level, no fix needed.

Best regards, Michael.

Re: Tramp sets LC_ALL to "C"

[Romain Francoise]

Hi Michael,

Michael Albinus <michael.albinus@gmx.de> writes:

> Should be OK now, using a local copy of `process-environment'.

Great, thanks for the quick fix.

> That's EMACS_22_BASE. `process-environment' is already let-bound
> at the right level, no fix needed.

Ok, I hadn't noticed.  Sorry.  :)