* ido.el-emitted trailing blank line vs write-hook
@ 2008-05-04 14:09 Jim Meyering
2008-05-17 6:25 ` Michael Olson
0 siblings, 1 reply; 3+ messages in thread
From: Jim Meyering @ 2008-05-04 14:09 UTC (permalink / raw)
To: Kim F. Storm, Emacs development discussions
Hi,
I've switched(sic ;-) to your ido.el package, and do like it (thanks!).
However, I find it annoying that my white-space removing write-hook
is nagging me about an ido-internal file.
The attached patch solves the problem for me, but I'll bet there's
a way to make it so a user-supplied write hook won't even consider
such a file.
Jim
From 3685ae3ab73da79bfaf774478f1d32feb66ec3cd Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Thu, 3 Apr 2008 16:40:49 +0200
Subject: [PATCH] edo: do not emit trailing newline
Signed-off-by: Jim Meyering <meyering@redhat.com>
---
lisp/ido.el | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/lisp/ido.el b/lisp/ido.el
index 314f495..090dca0 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -1317,7 +1317,6 @@ Value is an integer which is number of chars to right of prompt.")
(if (listp ido-unc-hosts-cache)
(ido-pp 'ido-unc-hosts-cache)
(insert "\n;; ----- ido-unc-hosts-cache -----\nt\n"))
- (insert "\n")
(write-file ido-save-directory-list-file nil))
(kill-buffer buf)))))
--
1.5.5.1.117.ga349
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: ido.el-emitted trailing blank line vs write-hook
2008-05-04 14:09 ido.el-emitted trailing blank line vs write-hook Jim Meyering
@ 2008-05-17 6:25 ` Michael Olson
2008-05-17 23:18 ` Kim F. Storm
0 siblings, 1 reply; 3+ messages in thread
From: Michael Olson @ 2008-05-17 6:25 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
Jim Meyering <jim@meyering.net> writes:
> I've switched(sic ;-) to your ido.el package, and do like it (thanks!).
> However, I find it annoying that my white-space removing write-hook
> is nagging me about an ido-internal file.
>
> The attached patch solves the problem for me, but I'll bet there's
> a way to make it so a user-supplied write hook won't even consider
> such a file.
I've applied this patch to HEAD.
--
| Michael Olson | FSF Associate Member #652 |
| http://mwolson.org/ | Hobbies: Lisp, HCoop |
| Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |
`-------------------------------------------------------'
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ido.el-emitted trailing blank line vs write-hook
2008-05-17 6:25 ` Michael Olson
@ 2008-05-17 23:18 ` Kim F. Storm
0 siblings, 0 replies; 3+ messages in thread
From: Kim F. Storm @ 2008-05-17 23:18 UTC (permalink / raw)
To: Michael Olson; +Cc: emacs-devel
Michael Olson <mwolson@gnu.org> writes:
> Jim Meyering <jim@meyering.net> writes:
>
>> I've switched(sic ;-) to your ido.el package, and do like it (thanks!).
>> However, I find it annoying that my white-space removing write-hook
>> is nagging me about an ido-internal file.
>>
>> The attached patch solves the problem for me, but I'll bet there's
>> a way to make it so a user-supplied write hook won't even consider
>> such a file.
>
> I've applied this patch to HEAD.
Thank you.
I'm sorry not to have done this myself long ago - but I have
absolutely zero time to work on Emacs currently.
I read the bugs and devel list at rather irregular intervals (and have
to skip over a lot of stuff) - mainly to see if anything really
catastrophic is reported with the packages I maintain (sort of).
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-17 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-04 14:09 ido.el-emitted trailing blank line vs write-hook Jim Meyering
2008-05-17 6:25 ` Michael Olson
2008-05-17 23:18 ` Kim F. Storm
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.