From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 1174@emacsbugs.donarmstrong.com,
Frank Schmitt <ich@frank-schmitt.net>,
ding@gnus.org, Simon Josefsson <jas@extundo.com>
Subject: bug#1174: 23.0.60; Some UTF-8 mails displaying wrongly in Emacs 23
Date: Mon, 01 Dec 2008 23:48:32 +0100 [thread overview]
Message-ID: <87y6yzbjgf.fsf__4765.47294897518$1228173114$gmane$org@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <jwv7i6j393g.fsf-monnier+emacsbugreports@gnu.org> (Stefan Monnier's message of "Mon, 01 Dec 2008 16:04:01 -0500")
On Mon, Dec 01 2008, Stefan Monnier wrote:
> Having looked at the code again, I'm more than ever confident that
> string-to-unibyte is the right thing to use. Maybe the code I installed
> back then failed to fallback to string-as-unibyte when string-to-unibyte
> was not available, which caused a bug for Simon?
Yes, it didn't fall back to string-as-unibyte:
--- nnimap.el 17 Aug 2004 14:27:16 -0000 7.7
+++ nnimap.el 30 Aug 2004 18:13:58 -0000 7.8
[...]
@@ -845,9 +847,12 @@
(nnoo-status-message 'nnimap server)))
(defun nnimap-demule (string)
- (funcall (if (and (fboundp 'string-as-multibyte)
- (subrp (symbol-function 'string-as-multibyte)))
- 'string-as-multibyte
+ ;; BEWARE: we used to use string-as-multibyte here which is braindead
+ ;; because it will turn accidental emacs-mule-valid byte sequences
+ ;; into multibyte chars. --Stef
+ (funcall (if (and (fboundp 'string-to-multibyte)
+ (subrp (symbol-function 'string-to-multibyte)))
+ 'string-to-multibyte
'identity)
(or string "")))
> In any case the newly committed code has a prenthesis typo that makes
> it still use the old code and ignore the new config var
> nnimap-demule-use-string-to-multibyte.
Oops, stupid me.
> Also I recommend to just use the patch below instead. The first hunk
> removes an unnecessary use of nnimap-demule since the output will be
> inserted into a unibyte buffer.
Thanks for your analysis. Please install the patch. I'll pull it into
Gnus CVS ASAP (unless Miles syncs first).
> +;; We used to use a string-as-multibyte here, but it is really incorrect.
> +;; This function is used when we're about to insert a unibyte string
> +;; into a potentially multibyte buffer. The string is either an article
> +;; header or body (or both?), undecoded. When Emacs is asked to convert
> +;; a unibyte string to multibyte, it may either use the equivalent of
> +;; nothing (e.g. non-Mule XEmacs), string-make-unibyte (i.e. decode using
> +;; locale), string-as-multibyte (decode using emacs-internal coding system)
> +;; or string-to-multibyte (keep the data undecoded as a sequence of bytes).
> +;; Only the last one preserves the data such that we can reliably later on
> +;; decode the text using the mime info.
> +(defalias 'nnimap-demule 'mm-string-to-multibyte)
In Emacs 21 (which Gnus still aim to be compatible with), we have
string-as-multibyte, but not string-to-multibyte. So your proposed
code (i.e. mm-string-to-multibyte) runs
(string-as-multibyte (char-to-string string))
whereas we used to run
(string-as-multibyte string)
Does char-to-string matter here?
(defalias 'mm-string-to-multibyte
(cond
((featurep 'xemacs)
'identity)
((fboundp 'string-to-multibyte)
'string-to-multibyte)
(t
(lambda (string)
"Return a multibyte string with the same individual chars as string."
(mapconcat
(lambda (ch) (mm-string-as-multibyte (char-to-string ch)))
string "")))))
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
next prev parent reply other threads:[~2008-12-01 22:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <jwviqpz1u4o.fsf-monnier+emacsbugreports@gnu.org>
2008-10-15 20:21 ` bug#1174: 23.0.60; Some UTF-8 mails displaying wrongly in Emacs 23 Frank Schmitt
2008-10-16 7:32 ` Andreas Schwab
2008-10-16 8:36 ` Frank Schmitt
2008-10-16 17:39 ` Eli Zaretskii
2008-10-16 18:00 ` Frank Schmitt
2008-10-16 18:15 ` Eli Zaretskii
2008-10-16 20:05 ` Frank Schmitt
2008-10-17 8:28 ` Andreas Schwab
2008-10-17 8:52 ` Frank Schmitt
2008-10-17 9:53 ` Eli Zaretskii
2008-10-17 10:02 ` Frank Schmitt
2008-10-17 10:08 ` Frank Schmitt
2008-10-17 15:39 ` Stefan Monnier
2008-10-17 18:19 ` Reiner Steib
[not found] ` <871vyf6q40.fsf@marauder.physik.uni-ulm.de>
2008-10-17 18:36 ` Frank Schmitt
[not found] ` <m3ej2fdq5x.fsf@mid.gehheimdienst.de>
2008-11-29 12:08 ` Reiner Steib
[not found] ` <87k5ampwej.fsf@marauder.physik.uni-ulm.de>
2008-11-29 12:18 ` Simon Josefsson
[not found] ` <878wr2ohde.fsf@mocca.josefsson.org>
2008-11-29 15:30 ` Reiner Steib
[not found] ` <87d4geim7p.fsf@marauder.physik.uni-ulm.de>
2008-11-29 21:30 ` Stefan Monnier
2008-11-29 22:14 ` James Cloos
[not found] ` <jwvfxlaz0ov.fsf-monnier+emacsbugreports@gnu.org>
2008-11-30 13:12 ` Reiner Steib
2009-01-12 10:54 ` Simon Josefsson
2009-01-12 11:03 ` Frank Schmitt
[not found] ` <m3d4es3hxu.fsf@mid.gehheimdienst.de>
2009-01-12 11:10 ` Simon Josefsson
[not found] ` <873afoixtr.fsf@mocca.josefsson.org>
[not found] ` <x6ab9u2kxr@gzp>
2009-01-14 20:12 ` Reiner Steib
[not found] ` <877i4xlk97.fsf@marauder.physik.uni-ulm.de>
2009-01-14 20:20 ` Processed: " Emacs bug Tracking System
2009-01-14 22:08 ` Stefan Monnier
2008-12-01 21:04 ` Stefan Monnier
[not found] ` <jwv7i6j393g.fsf-monnier+emacsbugreports@gnu.org>
2008-12-01 22:48 ` Reiner Steib [this message]
[not found] ` <87y6yzbjgf.fsf@marauder.physik.uni-ulm.de>
2008-12-02 7:36 ` Stefan Monnier
[not found] ` <jwv3ah7av77.fsf-monnier+emacsbugreports@gnu.org>
2008-12-04 19:43 ` Reiner Steib
[not found] ` <87iqpz4tg2.fsf@marauder.physik.uni-ulm.de>
2008-12-04 21:43 ` Frank Schmitt
2008-10-23 7:24 ` Frank Schmitt
2008-10-23 13:58 ` Stefan Monnier
2008-10-17 9:12 ` Frank Schmitt
2008-10-17 5:15 ` Richard M. Stallman
2008-10-28 22:54 ` James Cloos
2008-12-04 22:05 ` bug#1174: marked as done (23.0.60; Some UTF-8 mails displaying wrongly in Emacs 23) Emacs bug Tracking System
2009-02-18 8:55 ` Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87y6yzbjgf.fsf__4765.47294897518$1228173114$gmane$org@marauder.physik.uni-ulm.de' \
--to=reinersteib+gmane@imap.cc \
--cc=1174@emacsbugs.donarmstrong.com \
--cc=Reiner.Steib@gmx.de \
--cc=ding@gnus.org \
--cc=ich@frank-schmitt.net \
--cc=jas@extundo.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.