From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sven Joachim Newsgroups: gmane.emacs.bugs Subject: bug#1655: 23.0.60; visiting tarball marks the buffer as modified Date: Tue, 23 Dec 2008 17:27:00 +0100 Message-ID: <87y6y6uaaz.fsf@turtle.gmx.de> References: <87r641x55f.fsf@turtle.gmx.de> <87d4fjnmjj.fsf@turtle.gmx.de> Reply-To: Sven Joachim , 1655@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1230050650 16464 80.91.229.12 (23 Dec 2008 16:44:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Dec 2008 16:44:10 +0000 (UTC) To: 1655@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 23 17:45:13 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LFANM-0006Hd-Hi for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Dec 2008 17:44:56 +0100 Original-Received: from localhost ([127.0.0.1]:37994 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LFAM9-0005nU-M0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Dec 2008 11:43:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LFAM1-0005k4-5V for bug-gnu-emacs@gnu.org; Tue, 23 Dec 2008 11:43:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LFALt-0005fq-7T for bug-gnu-emacs@gnu.org; Tue, 23 Dec 2008 11:43:27 -0500 Original-Received: from [199.232.76.173] (port=52188 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LFALs-0005eq-JB for bug-gnu-emacs@gnu.org; Tue, 23 Dec 2008 11:43:24 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:57850) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LFALq-00085b-CA for bug-gnu-emacs@gnu.org; Tue, 23 Dec 2008 11:43:22 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBNGhK6d025819; Tue, 23 Dec 2008 08:43:20 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mBNGU3cD021005; Tue, 23 Dec 2008 08:30:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Sven Joachim Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 23 Dec 2008 16:30:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1655 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1655-submit@emacsbugs.donarmstrong.com id=B1655.123004964320636 (code B ref 1655); Tue, 23 Dec 2008 16:30:03 +0000 Original-Received: (at 1655) by emacsbugs.donarmstrong.com; 23 Dec 2008 16:27:23 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id mBNGRE4p020591 for <1655@emacsbugs.donarmstrong.com>; Tue, 23 Dec 2008 08:27:16 -0800 Original-Received: (qmail invoked by alias); 23 Dec 2008 16:27:07 -0000 Original-Received: from p548649B4.dip.t-dialin.net (EHLO turtle.gmx.de) [84.134.73.180] by mail.gmx.net (mp040) with SMTP; 23 Dec 2008 17:27:07 +0100 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX1+DiwAjNkGD/8HHf7tuMvO1qQu/acXmnZULZuAvIM tbrDRqVl56PZLi Original-Received: by turtle.gmx.de (Postfix, from userid 1000) id 0363D354B0; Tue, 23 Dec 2008 17:27:00 +0100 (CET) In-Reply-To: <87d4fjnmjj.fsf@turtle.gmx.de> (Sven Joachim's message of "Tue, 23 Dec 2008 12:44:32 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.5600000000000001 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 23 Dec 2008 11:43:27 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23450 Archived-At: tags 1655 + patch thanks On 2008-12-23 12:44 +0100, Sven Joachim wrote: > On 2008-12-21 10:13 +0100, Sven Joachim wrote: > >> Visiting a tar archive results in the buffer containing its contents >> being marked as modified. > > While this showed up fairly recently, the problem probably has existed > for much longer, but had been hidden by bug #1509 (epa-find-file-hook > marking the buffer as unmodified). > > Will investigate this issue further if time permits. Found out that the problem is in the buffer-swap-text calls in tar-mode and tar-change-major-mode-hook that change the buffer. The following patch works for me: 2008-12-23 Sven Joachim * tar-mode.el (tar-mode, tar-change-major-mode-hook): Avoid marking buffer as modified. --8<---------------cut here---------------start------------->8--- --- tar-mode.el.~1.130.~ 2008-06-01 10:42:56.000000000 +0200 +++ tar-mode.el 2008-12-23 17:11:12.000000000 +0100 @@ -577,8 +577,10 @@ (put 'tar-subfile-mode 'mode-class 'special) (defun tar-change-major-mode-hook () - ;; Bring the actual Tar data back into the main buffer. - (when (tar-data-swapped-p) (buffer-swap-text tar-data-buffer)) + (let ((modified-p (buffer-modified-p))) + ;; Bring the actual Tar data back into the main buffer. + (when (tar-data-swapped-p) (buffer-swap-text tar-data-buffer)) + (restore-buffer-modified-p modified-p)) ;; Throw away the summary. (when (buffer-live-p tar-data-buffer) (kill-buffer tar-data-buffer))) @@ -630,8 +632,10 @@ (generate-new-buffer (format " *tar-data %s*" (file-name-nondirectory (or buffer-file-name (buffer-name)))))) - (buffer-swap-text tar-data-buffer) - (tar-summarize-buffer) + (let ((modified-p (buffer-modified-p))) + (buffer-swap-text tar-data-buffer) + (tar-summarize-buffer) + (restore-buffer-modified-p modified-p)) (tar-next-line 0)) --8<---------------cut here---------------end--------------->8---