bug#4349: 23.1; bookmark-bmenu-rename call two times bookmark-bmenu-alist

[Thierry Volpiatto <thierry.volpiatto@gmail.com>]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Hi,

bookmark-bmenu-rename call `bookmark-bmenu-list' after `bookmark-rename'
that call itself `bookmark-bmenu-surreptitiously-rebuild-list'.

That's non--sense.

,----[ bookmark-rename ]
|     (bookmark-set-name old newname)
|     (setq bookmark-current-bookmark newname)
|     (bookmark-bmenu-surreptitiously-rebuild-list)
|     (setq bookmark-alist-modification-count
|           (1+ bookmark-alist-modification-count))
|     (if (bookmark-time-to-save-p)
|         (bookmark-save))))
`----

,----[ bookmark-bmenu-rename ]
|         (bookmark-rename bmrk)
|         (bookmark-bmenu-list)
|         (goto-char thispoint))))
`----

The call to bookmark-bmenu-list should be removed:

,----
| (defun bookmark-bmenu-rename ()
|   "Rename bookmark on current line.  Prompts for a new name."
|   (interactive)
|   (if (bookmark-bmenu-check-position)
|       (let ((bmrk (bookmark-bmenu-bookmark))
|             (thispoint (point)))
|         (bookmark-rename bmrk)
|         (goto-char thispoint))))
`----



 

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.1/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-07-31 on tux
Windowing system distributor `The X.Org Foundation', version 11.0.10503000
configured using `configure  '--prefix=/usr' '--build=i686-pc-linux-gnu' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--program-suffix=-emacs-23' '--infodir=/usr/share/info/emacs-23' '--with-sound' '--with-x' '--without-toolkit-scroll-bars' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xpm' '--with-xft' '--without-libotf' '--without-m17n-flt' '--with-x-toolkit=gtk' '--without-hesiod' '--without-kerberos' '--without-kerberos5' '--with-gpm' '--with-dbus' 'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu' 'CFLAGS=-march=i686 -pipe -O2' 'LDFLAGS=-Wl,-O1''

Important settings:
  value of $LC_ALL: fr_FR.UTF-8
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: fr_FR.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  eldoc-mode: t
  icomplete-mode: t
  icicle-mode: t
  delete-selection-mode: t
  minibuffer-depth-indicate-mode: t
  auto-image-file-mode: t
  shell-dirtrack-mode: t
  partial-completion-mode: t
  show-paren-mode: t
  display-battery-mode: t
  display-time-mode: t
  diff-auto-refine-mode: t
  outline-minor-mode: t
  recentf-mode: t
  savehist-mode: t
  desktop-save-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<f11> a C-g <switch-frame> <up> <up> <right> <right> 
<right> <right> <right> <right> <right> <left> <left> 
<left> <left> <left> <left> <left> w i t h SPC b a 
t c h SPC a r g SPC <down> <return> I f SPC y o u SPC 
m a k e SPC t h i s SPC c h a n g e , SPC y o u SPC 
w i l l SPC p r o b a l <backspace> b l y SPC w a n 
t SPC t o SPC r e m o v e SPC u n u s e d SPC s a v 
i n g SPC c o d e SPC i n SPC <switch-frame> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> C-SPC 
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f M-w <switch-frame> C-M-` C-y 
<right> . <up> <up> <return> N O T E : C-c C-c C-x 
C-& <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> M-x M-p <return> 
C-g M-x M-p <return>

Recent messages:
Mark set [2 times]
Auto-saving...done
Auto-saving...done
Sending...
Sending via mail...
Opening STARTTLS connection to `smtp.gmail.com:587'...done
Opening nnml server...done
Wrote /home/thierry/Mail/sent-mail/848
Sending...done
Opendns have been Updated

-- 
A + Thierry Volpiatto
Location: Saint-Cyr-Sur-Mer - France