From: Ted Zlatanov <tzz@lifelogs.com>
To: bug-gnu-emacs@gnu.org
Cc: kai.tetzlaff@web.de
Subject: Re: bug#4883: 23.1; url-http: wrong server name used for pwd lookup during proxy authentication
Date: Tue, 17 Nov 2009 09:19:00 -0600 [thread overview]
Message-ID: <87y6m5facb.fsf@lifelogs.com> (raw)
In-Reply-To: 87vdhinnxw.fsf@lifelogs.com
On Tue, 10 Nov 2009 14:07:39 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote:
TZ> On Sat, 07 Nov 2009 12:43:01 +0100 Kai Tetzlaff <kai.tetzlaff@web.de> wrote:
KT> There might be a better solution from someone who has a deeper understanding
KT> of the code in the url lib. But the following solves the problem - at least
KT> for my case:
KT> Index: lisp/url/url-http.el
KT> ===================================================================
KT> RCS file: /cvsroot/emacs/emacs/lisp/url/url-http.el,v
KT> retrieving revision 1.64
KT> diff -u -r1.64 url-http.el
KT> --- lisp/url/url-http.el 1 Oct 2009 02:06:55 -0000 1.64
KT> +++ lisp/url/url-http.el 6 Nov 2009 10:25:02 -0000
KT> @@ -315,12 +315,16 @@
KT> '("basic")))
KT> (type nil)
KT> (url (url-recreate-url url-current-object))
KT> - (url-basic-auth-storage 'url-http-real-basic-auth-storage)
KT> + (auth-url (url-recreate-url
KT> + (if (and proxy (boundp 'url-http-proxy))
KT> + url-http-proxy
KT> + url-current-object)))
KT> + (url-basic-auth-storage (if proxy
KT> + ;; Cheating, but who cares? :)
KT> + 'url-http-proxy-basic-auth-storage
KT> + 'url-http-real-basic-auth-storage))
KT> auth
KT> (strength 0))
KT> - ;; Cheating, but who cares? :)
KT> - (if proxy
KT> - (setq url-basic-auth-storage 'url-http-proxy-basic-auth-storage))
KT> ;; find strongest supported auth
KT> (dolist (this-auth auths)
KT> @@ -347,7 +351,7 @@
KT> " send it to " url-bug-address ".<hr>")
KT> (setq status t))
KT> (let* ((args (url-parse-args (subst-char-in-string ?, ?\; auth)))
KT> - (auth (url-get-authentication url (cdr-safe (assoc "realm" args))
KT> + (auth (url-get-authentication auth-url (cdr-safe (assoc "realm" args))
KT> type t args)))
KT> (if (not auth)
KT> (setq success t)
TZ> I introduced the auth-source hooks in url-http.el but the question of
TZ> which URL needs to be authenticated is not something I considered. Can
TZ> we hook the auth at a lower point? I'm concerned that if the proxy and
TZ> the destination URL both need authentication, your proposal won't work.
Kai, can you please follow up with your opinion?
Thanks
Ted
next prev parent reply other threads:[~2009-11-17 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.10227.1257614108.2239.bug-gnu-emacs@gnu.org>
2009-11-10 20:07 ` bug#4883: 23.1; url-http: wrong server name used for pwd lookup during proxy authentication Ted Zlatanov
2009-11-17 15:19 ` Ted Zlatanov [this message]
2009-11-24 6:36 ` Kai Tetzlaff
[not found] ` <mailman.11385.1259045252.2239.bug-gnu-emacs@gnu.org>
2009-11-25 14:51 ` Ted Zlatanov
2009-11-27 21:37 ` Kai Tetzlaff
[not found] ` <mailman.11677.1259358453.2239.bug-gnu-emacs@gnu.org>
2009-12-01 15:20 ` Ted Zlatanov
2009-11-07 11:43 Kai Tetzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y6m5facb.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=bug-gnu-emacs@gnu.org \
--cc=kai.tetzlaff@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.