bug#3166: browse-url: browse-url-firefox url encoding

bug#3166: browse-url: browse-url-firefox url encoding

[Christoph Conrad]

In GNU Emacs 22.3.1 (i686-pc-linux-gnu)
 of 2008-10-30 on brabbelbox
Windowing system distributor `The X.Org Foundation', version 11.0.10502000
configured using `configure  'CC=gcc''

`browse-url-firefox': There is an encoding of chars of the url at the
beginning.

;; URL encode any `confusing' characters in the URL.  This needs to
;; include at least commas; presumably also close parens.
  (while (string-match "[,)]" url)
    (setq url (replace-match
               (format "%%%x" (string-to-char (match-string 0 url))) t t url)))

For the _encoded_ url the displayed page in FF 3.0.10 is not the page
displayed when copying the _unencoded_ url directly in the browser
adress bar.

I tested this also by directly copying the urls into Opera 9.64 AND even
encoding the url with `browse-url-firefox' from current CVS emacs.

Regards,
Christoph

Example:

http://www.z-ac.de/component/option,com_eventlist/Itemid,23/func,details/did,761/
=>
http://www.z-ac.de/component/option%2ccom_eventlist/Itemid%2c23/func%2cdetails/did%2c761/

bug#3166: browse-url: browse-url-firefox url encoding

[Chong Yidong]

> For the _encoded_ url the displayed page in FF 3.0.10 is not the page
> displayed when copying the _unencoded_ url directly in the browser
> adress bar.
>
> I tested this also by directly copying the urls into Opera 9.64 AND even
> encoding the url with `browse-url-firefox' from current CVS emacs.
>
> Example:
>
> http://www.z-ac.de/component/option,com_eventlist/Itemid,23/func,details/did,761/
> =>
> http://www.z-ac.de/component/option%2ccom_eventlist/Itemid%2c23/func%2cdetails/did%2c761/

Thanks, I've checked in a change that removes the encoding of commas.
(It's possible the entire encoding process is bogus, but I left the rest
in place for now.)