From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#5475: Archives with filenames with square brackets Date: Sun, 31 Jan 2010 00:59:12 +0200 Organization: JURTA Message-ID: <87y6jfcg8b.fsf@mail.jurta.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1264897265 499 80.91.229.12 (31 Jan 2010 00:21:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 31 Jan 2010 00:21:05 +0000 (UTC) Cc: 5475@debbugs.gnu.org, Chong Yidong To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 31 01:21:02 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NbNYj-00084f-Cs for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Jan 2010 01:21:01 +0100 Original-Received: from localhost ([127.0.0.1]:47639 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NbNYi-0001St-G4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Jan 2010 19:21:00 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NbNYd-0001Se-VL for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2010 19:20:55 -0500 Original-Received: from [199.232.76.173] (port=36114 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NbNYc-0001SW-Ij for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2010 19:20:54 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NbNYb-00026i-3e for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2010 19:20:54 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36924) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NbNYa-00026c-Ry for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2010 19:20:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NbNBV-0007Ca-Up; Sat, 30 Jan 2010 18:57:01 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jan 2010 23:57:01 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5475 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5475-submit@debbugs.gnu.org id=B5475.126489580227651 (code B ref 5475); Sat, 30 Jan 2010 23:57:01 +0000 Original-Received: (at 5475) by debbugs.gnu.org; 30 Jan 2010 23:56:42 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbNBB-0007Bw-OG for submit@debbugs.gnu.org; Sat, 30 Jan 2010 18:56:42 -0500 Original-Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NbNB9-0007Bf-DX for 5475@debbugs.gnu.org; Sat, 30 Jan 2010 18:56:39 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.68.107.cable.starman.ee [82.131.68.107]) by mx2.starman.ee (Postfix) with ESMTP id 3CC033F40CF; Sun, 31 Jan 2010 01:56:30 +0200 (EET) In-Reply-To: <838wbiszy7.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 28 Jan 2010 23:05:04 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 30 Jan 2010 18:57:01 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34817 Archived-At: >> >> Well, archive-zip-extract already branches for pkzip/unzip >> > >> > Yes, but it does that by a user option, not by some hidden knowledge. >> > I won't mind introducing a similar option that would tell arc-mode to >> > quote the file arguments. >> >> Right, but once the user tells arc-mode to use unzip, we can >> automagically shell-quote the filename; there seems to be no reason not >> to. > > If you want to glean the need for quoting from the value of > archive-zip-extract (i.e. its car being "unzip"), I'm fine with that > as well. But as your patch is written, it imposes that on any unzip > command, regardless of whether it was "unzip" or something else, like > p7zip, for example. That doesn't seem right to me. I don't understand how this was supposed to work at all? The default value of `archive-zip-extract' can be either "unzip" or "pkunzip" (depending on the presence of the executable in `exec-path'), but the function `archive-zip-extract' compares with the value "pkzip". So the pkzip/pkunzip branch is never executed. It seems the intention of the change revno#45347 (2002-05-19) was to compare with "pkunzip" instead of "pkzip", but I currently can't confirm that since I can't find pkunzip for GNU/Linux. -- Juri Linkov http://www.jurta.org/emacs/