From: Juri Linkov <juri@jurta.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 5475@debbugs.gnu.org, Chong Yidong <cyd@stupidchicken.com>
Subject: bug#5475: Archives with filenames with square brackets
Date: Sun, 31 Jan 2010 00:59:12 +0200 [thread overview]
Message-ID: <87y6jfcg8b.fsf@mail.jurta.org> (raw)
In-Reply-To: <838wbiszy7.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 28 Jan 2010 23:05:04 +0200")
>> >> Well, archive-zip-extract already branches for pkzip/unzip
>> >
>> > Yes, but it does that by a user option, not by some hidden knowledge.
>> > I won't mind introducing a similar option that would tell arc-mode to
>> > quote the file arguments.
>>
>> Right, but once the user tells arc-mode to use unzip, we can
>> automagically shell-quote the filename; there seems to be no reason not
>> to.
>
> If you want to glean the need for quoting from the value of
> archive-zip-extract (i.e. its car being "unzip"), I'm fine with that
> as well. But as your patch is written, it imposes that on any unzip
> command, regardless of whether it was "unzip" or something else, like
> p7zip, for example. That doesn't seem right to me.
I don't understand how this was supposed to work at all?
The default value of `archive-zip-extract' can be either "unzip" or
"pkunzip" (depending on the presence of the executable in `exec-path'),
but the function `archive-zip-extract' compares with the value "pkzip".
So the pkzip/pkunzip branch is never executed.
It seems the intention of the change revno#45347 (2002-05-19) was
to compare with "pkunzip" instead of "pkzip", but I currently can't
confirm that since I can't find pkunzip for GNU/Linux.
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2010-01-30 22:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 17:48 bug#5475: Archives with filenames with square brackets Juri Linkov
2010-01-26 21:05 ` Chong Yidong
2010-01-26 21:47 ` Eli Zaretskii
2010-01-27 16:57 ` Chong Yidong
2010-01-27 17:35 ` Eli Zaretskii
2010-01-28 20:07 ` Chong Yidong
2010-01-28 21:05 ` Eli Zaretskii
2010-01-28 21:24 ` Lennart Borgman
2010-01-28 22:00 ` Eli Zaretskii
2010-01-30 22:59 ` Juri Linkov [this message]
2010-01-31 4:18 ` Eli Zaretskii
2010-01-31 10:56 ` Juri Linkov
2010-01-31 18:04 ` Eli Zaretskii
2010-01-31 21:59 ` Juri Linkov
2010-02-01 4:15 ` Eli Zaretskii
2010-02-01 10:34 ` Juri Linkov
2010-02-01 11:48 ` Lennart Borgman
2010-02-01 15:43 ` Stefan Monnier
2010-02-01 21:55 ` Juri Linkov
2010-02-02 0:11 ` Lennart Borgman
2010-02-02 0:46 ` Juri Linkov
2010-02-02 4:03 ` Eli Zaretskii
2010-04-18 23:14 ` Juri Linkov
2010-02-01 19:49 ` Eli Zaretskii
2010-02-01 21:21 ` Drew Adams
2010-02-01 21:52 ` Eli Zaretskii
2010-02-01 22:04 ` Drew Adams
2010-02-01 22:39 ` Juri Linkov
2010-02-01 22:41 ` Lennart Borgman
2010-02-02 0:10 ` Lennart Borgman
2010-02-02 0:42 ` Juri Linkov
2010-02-02 1:30 ` Lennart Borgman
2010-02-02 10:03 ` Juri Linkov
2010-02-03 0:17 ` Lennart Borgman
2010-02-03 0:35 ` Juri Linkov
2010-02-03 23:54 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y6jfcg8b.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=5475@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.