all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Juanma Barranquero <lekktu@gmail.com>,
	Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99831: Scrolling commands which does not signal errors at top/bottom.
Date: Wed, 14 Apr 2010 19:49:10 +0300	[thread overview]
Message-ID: <87y6gq6la3.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvhbnj4az5.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 10 Apr 2010 10:51:43 -0400")

>>> Please add a new variable so we can do
>>> && NILP (Fmemq (current_kboard->Vlast_command, Vnewvariable))
>>> and let Lisp packages add their commands to that variable.
>
>> A new variable is added in this patch (that includes other changes as well):
>
> Looks good, thank you,

Looking now at such lines:

  (put 'scroll-up-command 'isearch-scroll t)
  (add-to-list 'scroll-preserve-screen-position-commands 'scroll-up-command)

suggests that something is wrong here.

Even though pager.el uses a list variable to define scrolling commands,
we already use symbol properties to define scrolling commands for isearch.

So now it looks too ugly to use different methods to do the same thing.

Wouldn't it better to define scrolling commands for scroll-preserve-screen-position
the same way with symbol properties?

-- 
Juri Linkov
http://www.jurta.org/emacs/




  reply	other threads:[~2010-04-14 16:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1NywTs-00007U-Lf@internal.in.savannah.gnu.org>
2010-04-06  0:51 ` [Emacs-diffs] /srv/bzr/emacs/trunk r99831: Scrolling commands which does not signal errors at top/bottom Juanma Barranquero
2010-04-06  0:59   ` Juri Linkov
2010-04-06  1:58     ` Juanma Barranquero
2010-04-06 16:12       ` Juri Linkov
2010-04-06 18:26         ` Juanma Barranquero
2010-04-06 20:19           ` Juri Linkov
2010-04-06 20:49             ` Juanma Barranquero
2010-04-06 21:06               ` Juri Linkov
2010-04-06 21:39                 ` Juanma Barranquero
2010-04-06 21:47                   ` Juanma Barranquero
2010-04-07 20:17                     ` Juri Linkov
2010-04-07 22:16                       ` Juanma Barranquero
2010-04-07 23:19                         ` Juri Linkov
2010-04-07 23:35                           ` Juanma Barranquero
2010-04-09 15:29                       ` Stefan Monnier
2010-04-09 22:46                         ` Juri Linkov
2010-04-10 14:51                           ` Stefan Monnier
2010-04-14 16:49                             ` Juri Linkov [this message]
2010-04-15  4:41                               ` Stefan Monnier
2010-04-15 23:56                                 ` Juri Linkov
2010-04-16  0:41                                   ` Stefan Monnier
2010-04-16  1:27                                     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6gq6la3.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.