all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#5719: [patch] fix bat-generic-mode highlighting pattern for CLI switch.
@ 2010-03-14 20:18 Oleksandr Gavenko
  2010-06-27 18:44 ` Chong Yidong
  0 siblings, 1 reply; 2+ messages in thread
From: Oleksandr Gavenko @ 2010-03-14 20:18 UTC (permalink / raw)
  To: 5719

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

Pattern for highlight '/help', '/query', '/a' like
command line options currently does not require
leading whitespace char but MUST.

If you use Cygwin/MSYS from bat file you can type expressions like

   ls dir/sub-dir

and '/sub-dir' unfortunately highlighted as CLI switch!

Switch which start with - or + properly required leading whitespaces.

There exist one situation then you must highlight switch
exactly at start of line (and so there are no any leading whitespaces)
because this line considered continuation of previous line
if previous line end with '^' char.

But this not true for command.com and so unusual situation
so we can ignore it.

So in patch I just improve pattern for '+'/'-', which already
do job right.

-- 
Best regards!

[-- Attachment #2: .patch --]
[-- Type: text/plain, Size: 717 bytes --]

=== modified file 'lisp/generic-x.el'
--- lisp/generic-x.el	2010-01-13 08:35:10 +0000
+++ lisp/generic-x.el	2010-03-14 20:03:59 +0000
@@ -508,8 +508,7 @@
      '("^[ \t]*\\(:\\sw+\\)"         1 font-lock-function-name-face t)
      '("\\(%\\sw+%\\)"               1 font-lock-variable-name-face t)
      '("\\(%[0-9]\\)"                1 font-lock-variable-name-face t)
-     '("\\(/[^/ \"\t\n]+\\)"         1 font-lock-type-face)
-     '("[\t ]+\\([+-][^\t\n\" ]+\\)" 1 font-lock-type-face)
+     '("[\t ]+\\([+-/][^\t\n\" ]+\\)" 1 font-lock-type-face)
      '("[ \t\n|]\\<\\([gG][oO][tT][oO]\\)\\>[ \t]*\\(\\sw+\\)?"
        (1 font-lock-keyword-face)
        (2 font-lock-function-name-face nil t))


^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#5719: [patch] fix bat-generic-mode highlighting pattern for CLI switch.
  2010-03-14 20:18 bug#5719: [patch] fix bat-generic-mode highlighting pattern for CLI switch Oleksandr Gavenko
@ 2010-06-27 18:44 ` Chong Yidong
  0 siblings, 0 replies; 2+ messages in thread
From: Chong Yidong @ 2010-06-27 18:44 UTC (permalink / raw)
  To: Oleksandr Gavenko; +Cc: 5719-done

> Pattern for highlight '/help', '/query', '/a' like command line
> options currently does not require leading whitespace char but MUST.

Thanks for the patch.  I've checked it in.






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-06-27 18:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-14 20:18 bug#5719: [patch] fix bat-generic-mode highlighting pattern for CLI switch Oleksandr Gavenko
2010-06-27 18:44 ` Chong Yidong

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.