all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jason Dunsmore <emacs-orgmode@dunsmor.com>
To: emacs-orgmode@gnu.org
Subject: Re: Crash of emacs when using SHIFT-TAB
Date: Mon, 05 Jul 2010 12:40:18 -0500	[thread overview]
Message-ID: <87y6dpg73x.fsf@riotblast.dunsmor.com> (raw)
In-Reply-To: 20AAFFE1-F2E6-4EF4-B914-6BAF9D17AF3B@gmail.com

Carsten Dominik <carsten.dominik@gmail.com> writes:

>> Hi
>>
>> my emacs is crashing quite regularly when I am using org-babel. Is
>> there a way to get a traceback or something similar which I could
>> submit to get an idea what is causing it?
>
> I think this has probably nothing to do with org-babel.  More likely,
> you are using org-indent-mode, on an Emacs version where it does not
> work.  Check the Org manual for the exact version of Emacs you need.

I was bitten by this same bug.  I narrowed it down to org-indent, but I
had no idea I should look in the manual to see which version of emacs
org-indent was compatible with.

Here's a patch that will make emacs display an error if org-indent is
loaded with an incompatible version of emacs:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org-indent.el b/lisp/org-indent.el
index 77411af..0ef8456 100644
--- a/lisp/org-indent.el
+++ b/lisp/org-indent.el
@@ -131,6 +131,18 @@ FIXME:  How to update when broken?"
       (setq org-indent-mode nil)
     (if org-indent-mode
        (progn
+          (destructuring-bind (maj min bld)
+              (mapcar 'string-to-number (split-string emacs-version "[.]"))
+            (let ((msg "Emacs 23.1.50.3 or greater is recommended for org-indent 
+              (when (< maj 23)
+                (display-warning 'org msg :warning))
+              (when (= maj 23)
+                (unless (>= bld 50)
+                  (display-warning 'org msg :warning)))
+              (when (and (= maj 23)
+                         (= bld 50))
+                (unless (>= min 1)
+                  (display-warning 'org msg :warning)))))
          (org-set-local 'indent-tabs-mode nil)
          (or org-indent-strings (org-indent-initialize))
          (when org-indent-mode-turns-off-org-adapt-indentation
--8<---------------cut here---------------end--------------->8---

Perhaps this would be better as a separate function:

--8<---------------cut here---------------start------------->8---
(defun org-version-check (version feature level)
  (destructuring-bind (rmaj rmin rbld)
      (mapcar 'string-to-number (split-string version "[.]"))
    (destructuring-bind (maj min bld)
	(mapcar 'string-to-number (split-string emacs-version "[.]"))
      (let ((msg (format "Emacs %s or greater is recommended for %s" version
			 feature)))
	(when (< maj rmaj)
	  (display-warning 'org msg level))
	(when (= maj rmaj)
	  (unless (>= min rmin)
	    (display-warning 'org msg level)))
	(when (and (= maj rmaj)
		   (= min rmin))
	  (unless (>= bld rbld)
	    (display-warning 'org msg level)))))))
--8<---------------cut here---------------end--------------->8---

It could then be called with:

(org-version-check "23.1.50" "org-indent" :warning)

I made it display a warning because org-indent seems to work almost
perfectly with the version of emacs I'm running (23.1.1).

Regards,
Jason

  reply	other threads:[~2010-07-05 17:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-05  9:23 Crash of emacs when using SHIFT-TAB Rainer M Krug
2010-07-05 12:47 ` Carsten Dominik
2010-07-05 17:40   ` Jason Dunsmore [this message]
2010-07-05 20:34     ` Rainer M Krug
2010-07-06  8:25     ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6dpg73x.fsf@riotblast.dunsmor.com \
    --to=emacs-orgmode@dunsmor.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.