From: Chong Yidong <cyd@stupidchicken.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org
Subject: bug#7587: 23.2; `format-mode-line' makes Emacs crash
Date: Mon, 20 Dec 2010 23:29:48 +0800 [thread overview]
Message-ID: <87y67k1mz7.fsf@stupidchicken.com> (raw)
In-Reply-To: <83r5dffoi5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Dec 2010 10:56:18 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> + : EQ (face, Qmode_line_inactive) ? MODE_LINE_FACE_ID
>
> I fixed these now.
Thanks.
> > I'm not even sure what the FACE argument to format-mode-line is
> > useful for
>
> The doc string and the ELisp manual clearly answer that question:
> format-mode-line can be used to compute the formatted string without
> displaying it. When you use this API that way, you can specify a face
> for the parts of mode line that don't have their faces specified in
> the mode-line format. IOW, it sounds like a deliberate feature, given
> the description in the ELisp manual.
>
> > it doesn't seem to be used anywhere in the sources.
>
> ?? init_iterator uses it (well, its index in the face cache) to
> initialize the appropriate member of the iterator object.
I mean, format-mode-line with a non-nil FACE argument doesn't seem to be
used anywhere.
> Given some history of discussions here, and the fact that no one seems
> to be sure how this code should really work and why, I wonder why you
> went ahead with the change without discussing it first. I'm afraid
> that this change breaks backward compatibility for no good reason.
Given that the backward compatible behavior is to segfault, this
breakage might be acceptable.
Less flippantly, the FACE argument, if non-nil, is still applied as a
text property to the returned string. So I don't think there's going to
be any noticeable difference (again, we don't have any concrete use
cases, so it's difficult to say). The docstring change might not even
be necessary.
next prev parent reply other threads:[~2010-12-20 15:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 21:01 bug#7587: 23.2; `format-mode-line' makes Emacs crash Michael Heerdegen
2010-12-10 16:02 ` Eli Zaretskii
2010-12-10 16:39 ` Eli Zaretskii
2010-12-10 20:50 ` Stefan Monnier
2010-12-10 22:40 ` Eli Zaretskii
2010-12-16 2:17 ` Chong Yidong
2010-12-16 4:39 ` Drew Adams
2010-12-16 5:37 ` Eli Zaretskii
2010-12-16 5:35 ` Eli Zaretskii
2010-12-18 8:56 ` Eli Zaretskii
2010-12-20 15:29 ` Chong Yidong [this message]
2010-12-20 18:33 ` Eli Zaretskii
2010-12-25 10:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y67k1mz7.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=7587@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.