From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ralph Schleicher Newsgroups: gmane.emacs.bugs Subject: bug#8261: Perl mode imenu index ignores my/our variables Date: Tue, 15 Mar 2011 21:34:27 +0100 Organization: Ralph Schleicher Message-ID: <87y64gi0mk.fsf@bravo.mueller-schleicher.i> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1300221462 21760 80.91.229.12 (15 Mar 2011 20:37:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 15 Mar 2011 20:37:42 +0000 (UTC) To: 8261@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 15 21:37:38 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pzazo-0000WI-7X for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Mar 2011 21:37:37 +0100 Original-Received: from localhost ([127.0.0.1]:40189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pzazn-00075h-AC for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Mar 2011 16:37:35 -0400 Original-Received: from [140.186.70.92] (port=40362 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzazO-0006u9-5L for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 16:37:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzazN-0005o2-3d for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 16:37:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzazN-0005ny-1v for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 16:37:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PzaxJ-0002dC-Ml; Tue, 15 Mar 2011 16:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ralph Schleicher Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Mar 2011 20:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8261 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.130022128410090 (code B ref -1); Tue, 15 Mar 2011 20:35:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Mar 2011 20:34:44 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pzax1-0002ch-4y for submit@debbugs.gnu.org; Tue, 15 Mar 2011 16:34:43 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pzawz-0002cV-1w for submit@debbugs.gnu.org; Tue, 15 Mar 2011 16:34:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pzaws-0005Eg-Ow for submit@debbugs.gnu.org; Tue, 15 Mar 2011 16:34:35 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:34616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pzaws-0005Ec-Mw for submit@debbugs.gnu.org; Tue, 15 Mar 2011 16:34:34 -0400 Original-Received: from [140.186.70.92] (port=39543 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pzawq-0005A1-KZ for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 16:34:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pzawn-0005Ci-V7 for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 16:34:32 -0400 Original-Received: from dd24230.kasserver.com ([85.13.143.176]:42976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pzawn-0005Bc-OE for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 16:34:29 -0400 Original-Received: from bravo.mueller-schleicher.de (p57ADB606.dip.t-dialin.net [87.173.182.6]) by dd24230.kasserver.com (Postfix) with ESMTPA id B97394A80AF for ; Tue, 15 Mar 2011 21:34:27 +0100 (CET) Original-Received: by bravo.mueller-schleicher.de (Postfix, from userid 1000) id 2DBC15C251; Tue, 15 Mar 2011 21:34:27 +0100 (CET) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 15 Mar 2011 16:35:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45058 Archived-At: Hi, in Perl mode the imenu index does not list variables declared via 'my' and 'our'. Below is a patch together with a change log entry to fix it. Please note that the regular expression is "\\(?:my\\|our\\))\\s-+" and not "\\(?:\\(?:my\\|our\\))\\s-+\\)?" (optional match). Not declaring global variables properly is generally considered bad Perl style. 2011-03-11 Ralph Schleicher * progmodes/perl-mode.el (perl-imenu-generic-expression): Only match variables declared via `my' or `our'. --- emacs-23.3/lisp/progmodes/perl-mode.el.orig 2011-01-08 12:45:14 +0100 +++ emacs-23.3/lisp/progmodes/perl-mode.el 2011-03-11 11:39:42 +0100 @@ -167,7 +167,7 @@ '(;; Functions (nil "^sub\\s-+\\([-A-Za-z0-9+_:]+\\)" 1) ;;Variables - ("Variables" "^\\([$@%][-A-Za-z0-9+_:]+\\)\\s-*=" 1) + ("Variables" "^\\(?:my\\|our\\)\\s-+\\([$@%][-A-Za-z0-9+_:]+\\)\\s-*=" 1) ("Packages" "^package\\s-+\\([-A-Za-z0-9+_:]+\\);" 1) ("Doc sections" "^=head[0-9][ \t]+\\(.*\\)" 1)) "Imenu generic expression for Perl mode. See `imenu-generic-expression'.") -- Ralph