From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Antoine Levitt Newsgroups: gmane.emacs.devel Subject: Re: ERC tracking broken Date: Wed, 30 Mar 2011 00:05:25 +0200 Message-ID: <87y63xoa56.fsf@gmail.com> References: <8739m54zz7.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1301436783 19485 80.91.229.12 (29 Mar 2011 22:13:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 Mar 2011 22:13:03 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 30 00:12:58 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4h8o-0001hI-5k for ged-emacs-devel@m.gmane.org; Wed, 30 Mar 2011 00:12:58 +0200 Original-Received: from localhost ([127.0.0.1]:36924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4h8d-0004p1-FD for ged-emacs-devel@m.gmane.org; Tue, 29 Mar 2011 18:11:47 -0400 Original-Received: from [140.186.70.92] (port=41724 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4h7r-0002MB-7u for emacs-devel@gnu.org; Tue, 29 Mar 2011 18:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4h2h-0001dn-9L for emacs-devel@gnu.org; Tue, 29 Mar 2011 18:05:40 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:36873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4h2g-0001dY-Uk for emacs-devel@gnu.org; Tue, 29 Mar 2011 18:05:39 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Q4h2f-0007Wa-IX for emacs-devel@gnu.org; Wed, 30 Mar 2011 00:05:37 +0200 Original-Received: from ney92-7-78-233-218-202.fbx.proxad.net ([78.233.218.202]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 30 Mar 2011 00:05:37 +0200 Original-Received: from antoine.levitt by ney92-7-78-233-218-202.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 30 Mar 2011 00:05:37 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 53 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: ney92-7-78-233-218-202.fbx.proxad.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137880 Archived-At: 29/03/11 23:20, Stefan Monnier >> ERC tracking seems to be broken. Reverting to the binary of emacs I >> compiled yesterday fixes it, so I strongly suspect it's a result of > >> commit 5e4cb836580a8ef2f9ea9b4b8317005941920027 >> Author: Stefan Monnier >> Date: Mon Mar 28 16:26:35 2011 -0400 >> Don't reset post-command-hook to nil upon error. > >> which interferes with a patch by Julien Danjou about using >> post-command-hook to notice window changes in erc-track. I don't >> remember the specifics though. > > My change should not affect the behavior of post-command-hook expect > when one of the hook functions signals an error (something that should > not happen, normally), so if it's due to my change, it's a bug in > my change. > > Do you have a recipe to reproduce the problem, starting from "emacs -Q" > (including for someone like me who basically never used IRC)? > > > Stefan Alright, I finally traced it back to something not ERC-related. The easiest way I could reproduce it is with some code to highlight parentheses. So here's a simple recipe: - Get http://pastebin.com/UafFZ9qy and put it in your load path (I got this code from emacswiki some time ago, it worked fine until today - which doesn't mean it's correct, maybe your changes simply exposed a bug in it) - Put (require 'highlight-parentheses) (global-highlight-parentheses-mode t) (ido-mode 1) (icomplete-mode 1) in a blank .emacs - M-x a, observe there's a nice completion list - C-g to get out of the completion - M-x a, observe the completion list has disappeared (for the rest of the session) This started occuring at some point today and the code uses post-command-hook, so it's probably related. Hope that helps Antoine