From: Antoine Levitt <antoine.levitt@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: ERC tracking broken
Date: Wed, 30 Mar 2011 00:05:25 +0200 [thread overview]
Message-ID: <87y63xoa56.fsf@gmail.com> (raw)
In-Reply-To: jwvoc4t62yz.fsf-monnier+emacs@gnu.org
29/03/11 23:20, Stefan Monnier
>> ERC tracking seems to be broken. Reverting to the binary of emacs I
>> compiled yesterday fixes it, so I strongly suspect it's a result of
>
>> commit 5e4cb836580a8ef2f9ea9b4b8317005941920027
>> Author: Stefan Monnier <monnier@iro.umontreal.ca>
>> Date: Mon Mar 28 16:26:35 2011 -0400
>> Don't reset post-command-hook to nil upon error.
>
>> which interferes with a patch by Julien Danjou about using
>> post-command-hook to notice window changes in erc-track. I don't
>> remember the specifics though.
>
> My change should not affect the behavior of post-command-hook expect
> when one of the hook functions signals an error (something that should
> not happen, normally), so if it's due to my change, it's a bug in
> my change.
>
> Do you have a recipe to reproduce the problem, starting from "emacs -Q"
> (including for someone like me who basically never used IRC)?
>
>
> Stefan
Alright, I finally traced it back to something not ERC-related. The
easiest way I could reproduce it is with some code to highlight
parentheses. So here's a simple recipe:
- Get http://pastebin.com/UafFZ9qy and put it in your load path (I got
this code from emacswiki some time ago, it worked fine until today -
which doesn't mean it's correct, maybe your changes simply exposed a
bug in it)
- Put
(require 'highlight-parentheses)
(global-highlight-parentheses-mode t)
(ido-mode 1)
(icomplete-mode 1)
in a blank .emacs
- M-x a, observe there's a nice completion list
- C-g to get out of the completion
- M-x a, observe the completion list has disappeared (for the rest
of the session)
This started occuring at some point today and the code uses
post-command-hook, so it's probably related.
Hope that helps
Antoine
next prev parent reply other threads:[~2011-03-29 22:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 17:07 ERC tracking broken Antoine Levitt
2011-03-29 21:20 ` Stefan Monnier
2011-03-29 22:05 ` Antoine Levitt [this message]
2011-03-30 0:56 ` Stefan Monnier
2011-03-30 5:59 ` Antoine Levitt
2011-04-04 15:54 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y63xoa56.fsf@gmail.com \
--to=antoine.levitt@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.