all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Meyering <jim@meyering.net>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: bug-gnulib <bug-gnulib@gnu.org>, 11905@debbugs.gnu.org
Subject: bug#11905: Unnecessary '#define unix' in src/s/aix4-2.h
Date: Wed, 11 Jul 2012 09:26:05 +0200	[thread overview]
Message-ID: <87y5mq69o2.fsf__16714.7476262928$1341991613$gmane$org@rho.meyering.net> (raw)
In-Reply-To: <4FFCC037.3050801@cs.ucla.edu> (Paul Eggert's message of "Tue, 10 Jul 2012 16:52:23 -0700")

Paul Eggert wrote:
> On 07/10/2012 04:25 PM, Glenn Morris wrote:
>> I suspect that Gnulib already has the AIX
>> case covered (via "__unix"?), so that src/s/aix4-2.h no longer needs to
>> define "unix".
>
> Yes, that sounds right.  I have started to fix this by
> installing the following patch into gnulib, and will
> propagate this into Emacs shortly.
>
> ---
>  ChangeLog        |    9 +++++++++
>  lib/getloadavg.c |   28 +++-------------------------
>  m4/getloadavg.m4 |    2 ++
>  3 files changed, 14 insertions(+), 25 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index d94f7b1..b27ef8d 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,12 @@
> +2012-07-10  Paul Eggert  <eggert@cs.ucla.edu>
> +
> +	getloadavg: clean out old Emacs and Autoconf cruft
> +	See Glenn Morris in <http://bugs.gnu.org/11905>.
> +	* lib/getloadavg.c: Include <config.h>, <stdbool.h> always.
> +	Include <sys/param.h> if HAVE_SYS_PARAM_H, not if unix or __unix.
> +	(LDAV_CVT): Remove no-longer-used LOAD_AVE_CVT hook.
> +	* m4/getloadavg.m4 (gl_PREREQ_GETLOADAVG): Check for <sys/param.h>.

Welcome clean-up.  Thanks!





      parent reply	other threads:[~2012-07-11  7:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10 23:25 bug#11905: Unnecessary '#define unix' in src/s/aix4-2.h Glenn Morris
2012-07-10 23:52 ` Paul Eggert
2012-07-11  0:01 ` Paul Eggert
     [not found] ` <4FFCC037.3050801@cs.ucla.edu>
2012-07-11  7:26   ` Jim Meyering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87y5mq69o2.fsf__16714.7476262928$1341991613$gmane$org@rho.meyering.net' \
    --to=jim@meyering.net \
    --cc=11905@debbugs.gnu.org \
    --cc=bug-gnulib@gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.