bug#12288: 24.2.50; compilation-start: Query for killing existing compilation process only if query-on-exit-flag is non-nil

[Christopher Schmidt <christopher@ch.ristopher.com>]

Martin Blais <blais@furius.ca> writes:
> I'm not sure I understand. Let's recap a bit:
>
> a. in 'compilation-start-hook, there's a hint that you can force the
> process-query-on-exit-flag on the compile process; that would
> presumably allow you to kill the buffer without a query, but not on a
                                                           ^^^^^^^^^^^^
> subsequent call to compile. (BTW I just tried the suggested hook as is
  ^^^^^^^^^^^^^^^^^^^^^^^^^^
> and it doesn't work for me, but that's another issue).

This is exactly what I don't want.

Those processes that have a nil query-on-exit-flag should be killed by
compilation-start without a yes-or-no query.  A buffer-local non-nil
value for compilation-always-kill allows me to achieve that.

I still think a check for query-on-exit-flag in compilation-start is a
good idea.  Non-nil query-on-exit-flag and non-nil buffer-local
compilation-always-kill feels redundant, doesn't it?

        Christopher