From: Jambunathan K <kjambunathan@gmail.com>
To: 11095@debbugs.gnu.org
Subject: bug#11095: 24.0.94; hi-lock-face-buffer/unhighlight-regexp': Augment?
Date: Fri, 12 Oct 2012 01:54:30 +0530 [thread overview]
Message-ID: <87y5jcvjsx.fsf@gmail.com> (raw)
In-Reply-To: <81d37z271c.fsf@gmail.com> (Jambunathan K.'s message of "Mon, 26 Mar 2012 12:16:55 +0530")
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
The attached patch, applies on top of earlier two patches. See
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11095#11
The patch allows highlighting of tag at point. (Note that for all
practical purposes, tag at point is the symbol at point.) See
Part_I/Item-2 below for a usecase.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: bug11095-part3.patch --]
[-- Type: text/x-diff, Size: 3440 bytes --]
=== modified file 'lisp/hi-lock.el'
--- lisp/hi-lock.el 2012-10-10 22:01:18 +0000
+++ lisp/hi-lock.el 2012-10-11 20:02:17 +0000
@@ -433,7 +433,7 @@ updated as you type."
(interactive
(list
(hi-lock-regexp-okay
- (read-regexp "Regexp to highlight line" (car regexp-history)))
+ (read-regexp "Regexp to highlight line"))
(hi-lock-read-face-name)))
(or (facep face) (setq face 'hi-lock-1))
(unless hi-lock-mode (hi-lock-mode 1))
@@ -458,7 +458,7 @@ updated as you type."
(interactive
(list
(hi-lock-regexp-okay
- (read-regexp "Regexp to highlight" (car regexp-history)))
+ (read-regexp "Regexp to highlight"))
(hi-lock-read-face-name)))
(or (facep face) (setq face 'hi-lock-1))
(unless hi-lock-mode (hi-lock-mode 1))
@@ -480,7 +480,7 @@ updated as you type."
(list
(hi-lock-regexp-okay
(hi-lock-process-phrase
- (read-regexp "Phrase to highlight" (car regexp-history))))
+ (read-regexp "Phrase to highlight")))
(hi-lock-read-face-name)))
(or (facep face) (setq face 'hi-lock-1))
(unless hi-lock-mode (hi-lock-mode 1))
@@ -598,7 +598,7 @@ When `hi-lock-auto-select-face' is non-n
from minibuffer with completion and history."
(if hi-lock-auto-select-face
;; Return current head and rotate the face list.
- (prog1 (car hi-lock-auto-select-face-defaults)
+ (prog1 (intern (car hi-lock-auto-select-face-defaults))
(setq hi-lock-auto-select-face-defaults
(cdr hi-lock-auto-select-face-defaults)))
(intern (completing-read
=== modified file 'lisp/replace.el'
--- lisp/replace.el 2012-10-04 19:28:11 +0000
+++ lisp/replace.el 2012-10-11 19:46:42 +0000
@@ -585,27 +585,32 @@ of `history-length', which see.")
When PROMPT doesn't end with a colon and space, it adds a final \": \".
If DEFAULTS is non-nil, it displays the first default in the prompt.
-Non-nil optional arg DEFAULTS is a string or a list of strings that
-are prepended to a list of standard default values, which include the
-string at point, the last isearch regexp, the last isearch string, and
-the last replacement regexp.
+Optional arg DEFAULTS is a string or a list of strings that are
+prepended to a list of standard default values, which include the
+tag at point, the last isearch regexp, the last isearch string,
+and the last replacement regexp.
Non-nil HISTORY is a symbol to use for the history list.
If HISTORY is nil, `regexp-history' is used."
- (let* ((default (if (consp defaults) (car defaults) defaults))
- (defaults
+ (let* ((defaults
(append
(if (listp defaults) defaults (list defaults))
- (list (regexp-quote
- (or (funcall (or find-tag-default-function
+ (list
+ ;; Regexp for tag at point.
+ (let* ((tagf (or find-tag-default-function
(get major-mode 'find-tag-default-function)
'find-tag-default))
- ""))
+ (tag (funcall tagf)))
+ (cond ((not tag) "")
+ ((eq tagf 'find-tag-default)
+ (format "\\_<%s\\_>" (regexp-quote tag)))
+ (t (regexp-quote tag))))
(car regexp-search-ring)
(regexp-quote (or (car search-ring) ""))
(car (symbol-value
query-replace-from-history-variable)))))
(defaults (delete-dups (delq nil (delete "" defaults))))
+ (default (car defaults))
;; Do not automatically add default to the history for empty input.
(history-add-new-input nil)
(input (read-from-minibuffer
[-- Attachment #3: Type: text/plain, Size: 5127 bytes --]
> Proposal is in two parts. Part-I deals with `hi-lock-face-buffer'.
> Part-II deals with `unhighlight-regexp'. Part-III has a dump of the
> current customization I have in my .emacs.
>
> I believe that my proposal is useful in general. So I request that it
> be folded in to Emacs-24.1.
>
> Part-I: `hi-lock-face-buffer' & Co.
> ----------------------------------
>
> 1) Review the face names used in `hi-lock-face-defaults' and make the
> faces customizable. The defaults may not look good on a user's his
> own font-lock configuration.
>
> 2) Make `hi-lock-face-buffer' use a different face on each invocation.
>
> Here is a real-world usecase for the above request.
>
> As a programmer, I use highlighting to trace variable dependencies
> within a function. For example, in the example below, after
> highlighting the variables in __different__ faces, I will come to the
> conclusion that "a" depends on "d" and "tmp".
>
> c = d;
> b = c + tmp;
> a = b;
>
> And I use this very often to track variables and how they get their
> values from.
>
> If I were to use the default Emacs provided behaviour then I would
> have to press M-n multiple times as I highlight more and more
> symbols. (Typically I have 3-5 symbols highlighted before I turn off
> highlighting.)
>
> See elisp snippet at the end of the mail.
>
>
> Part-II: `unhighlight-regexp'
> ------------------------------
>
> See usecase in Part-I/Item-2
>
> 1) I want to selectively turn-off highlighting for certain regexps
> (arguably) that _specific_ highlighted regexp cursor is stationed on.
> This would happen when I decide that I don't want to factor a
> particular variable for my current refactoring exercise.
>
> I find the current behaviour of `unhighlight-regexp' slightly
> tedious.
>
> 1. There is no completion for which regexp I want to unhighlight and
> I have to circle through `hi-lock-interactive-patterns'.
>
> 2. Browsing the `hi-lock-interactive-patterns' is tedious for the
> following reasons:
>
> - The order in which unhighlighting happens could totally be
> unrelated to the order in which highlighting happens. When I am
> analyzing the variable flow, I don't want to do a "context
> switch" trying to find out what item to choose from the
> `unhighlight-regexp' menu.
>
> 2) I want to unhighlight all regexps. This happens when I am done with
> variable analysis.
>
>
> ps: I am not questioning the current defaults. I am only saying that it
> the current behaviour is too generic to be immediately useful (atleast
> for my usecase) and so needs some sort of extra augmentation.
>
> Part-III: Elisp snippet
> -----------------------
>
> ;; Why should the color of the faces be encoded in the variable name?
> ;; Seems counter-intutitive to me. I cannot relate to a hi-yellow
> ;; face customized to render in red.
>
> ;; (defvar hi-lock-face-defaults
> ;; '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-black-b"
> ;; "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb")
> ;; "Default faces for hi-lock interactive functions.")
>
> ;; So roll out my own face for highlighting. Make them
> ;; __customizable__. Note that the name of the face doesn't say what
> ;; the color of the highlight will be. Works for the color theme that
> ;; I have.
> (custom-set-faces
> '(highlight1 ((t (:background "yellow" :foreground "black"))))
> '(highlight2 ((t (:background "OrangeRed" :foreground "black"))))
> '(highlight3 ((((class color) (background dark)) (:background "AntiqueWhite" :foreground "black"))))
> '(highlight4 ((t (:background "SystemHotTrackingColor"))))
> '(highlight5 ((t (:background "VioletRed" :foreground "black")))))
>
> ;; override the Emacs default
> (setq hi-lock-face-defaults
> '("highlight1" "highlight2" "highlight3" "highlight4" "highlight5"))
>
> (defvar hi-lock-faces
> (let ((l (copy-list hi-lock-face-defaults)))
> (setcdr (last l) l))
> "Circular list of faces in `hi-lock-face-defaults'.")
>
> ;; make `hi-lock-faces' buffer local
> (make-variable-buffer-local 'hi-lock-faces)
>
> (defun highlight-symbol ()
> "Highlight symbol at point.
> For illustartion only. Note the use of `hi-lock-face-buffer'.
> Choose a new face from `hi-lock-faces' on each invocation.
> Overrides the default behaviour in vanilla Emacs which is to use
> the face at the head of the list."
> (interactive)
> (hi-lock-face-buffer
> (concat "\\_<" (regexp-quote (thing-at-point 'symbol)) "\\_>")
> ;; rotate the face list
> (prog1 (car hi-lock-faces)
> (setq hi-lock-faces (cdr hi-lock-faces)))))
>
> (defun my-unhighlight-regexp (arg)
> "Wrapper around `unhighlight-regexp'.
> With a prefix argument, turn off all highlighting.
>
> TODO: Check if the symbol is right now on a highlighted regexp.
> If yes, unhighlight only that regexp."
> (interactive "P")
> (if arg
> (mapc (lambda (p)
> (unhighlight-regexp (car p)))
> hi-lock-interactive-patterns)
> (call-interactively 'unhighlight-regexp)))
>
>
>
>
--
next prev parent reply other threads:[~2012-10-11 20:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 6:46 bug#11095: 24.0.94; hi-lock-face-buffer/unhighlight-regexp': Augment? Jambunathan K
2012-10-10 20:21 ` bug#11095: [PATCH] " Jambunathan K
2012-12-04 21:14 ` Stefan Monnier
2012-12-04 21:39 ` Drew Adams
2012-12-04 21:57 ` Stefan Monnier
2012-12-04 22:43 ` Drew Adams
2012-12-05 3:46 ` Stefan Monnier
2012-12-05 22:15 ` Jambunathan K
2012-12-06 1:14 ` Stefan Monnier
2012-12-06 5:06 ` Jambunathan K
2012-12-06 14:50 ` Jambunathan K
2012-12-06 19:16 ` Stefan Monnier
2012-12-06 19:36 ` Drew Adams
2012-12-06 21:26 ` Jambunathan K
2012-12-06 21:36 ` Stefan Monnier
2012-12-06 22:23 ` Jambunathan K
2012-12-07 4:07 ` Stefan Monnier
2012-12-07 4:46 ` Jambunathan K
2012-12-07 16:55 ` Stefan Monnier
2012-12-08 12:50 ` Jambunathan K
2012-12-10 4:26 ` Jambunathan K
2012-12-10 18:34 ` Stefan Monnier
2012-12-10 20:37 ` Jambunathan K
2012-12-10 21:27 ` Stefan Monnier
2012-10-10 22:08 ` Jambunathan K
2012-10-11 20:24 ` Jambunathan K [this message]
2012-10-11 20:33 ` Jambunathan K
2012-10-11 22:41 ` Juri Linkov
2012-10-12 4:30 ` Jambunathan K
2012-10-13 16:10 ` Juri Linkov
2012-10-13 17:28 ` Jambunathan K
2012-10-12 16:17 ` Jambunathan K
2012-10-12 18:18 ` Jambunathan K
2012-10-12 19:32 ` bug#11095: [FINAL] " Jambunathan K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5jcvjsx.fsf@gmail.com \
--to=kjambunathan@gmail.com \
--cc=11095@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.