* Bug: Tag inheritance broken in agenda/timeline buffers [7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)]
@ 2013-01-10 7:43 Tassilo Horn
2013-01-10 8:33 ` Tassilo Horn
2013-01-10 10:45 ` Bastien
0 siblings, 2 replies; 5+ messages in thread
From: Tassilo Horn @ 2013-01-10 7:43 UTC (permalink / raw)
To: emacs-orgmode
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------
I have (all default values)
org-use-tag-inheritance t
org-agenda-use-tag-inheritance '(todo search timeline agenda)
org-agenda-show-inherited-tags t
but there are no inherited tags shown in the agenda or an org-buffer's
timeline.
When I press `T' on a agenda entry, the inherited tags are properly
messaged in the echo area, though. I'm sure it used to work, but I'm
not sure when it stopped working. When I find some time, I can try
bisecting.
BTW: What's the difference between `org-agenda-use-tag-inheritance' and
`org-agenda-show-inherited-tags'? Is there a difference between "using"
and "showing" tag inheritance?
Emacs : GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.6.2)
of 2013-01-01 on thinkpad
Package: Org-mode version 7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)
current state:
==============
(setq
org-export-preprocess-before-selecting-backend-code-hook '(org-beamer-select-beamer-code)
org-tab-first-hook '(org-hide-block-toggle-maybe org-src-native-tab-command-maybe
org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
outline-minor-mode-hook '(th-outline-minor-mode-init)
org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook)
org-gnus-prefer-web-links t
org-special-ctrl-k t
org-occur-hook '(org-first-headline-recenter)
org-src-tab-acts-natively t
org-metaup-hook '(org-babel-load-in-session-maybe)
org-export-preprocess-before-normalizing-links-hook '(org-remove-file-link-modifiers)
org-log-done 'time
org-confirm-shell-link-function 'yes-or-no-p
org-complete-tags-always-offer-all-agenda-tags t
org-id-link-to-org-use-id t
org-finalize-agenda-hook '(th-org-agenda-to-appt)
org-columns-default-format "%50ITEM %TODO %ALLTAGS %SCHEDULED %DEADLINE"
org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc
org-beamer-auto-fragile-frames
org-beamer-place-default-actions-for-lists)
org-agenda-restore-windows-after-quit t
org-special-ctrl-a/e 'reversed
org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
org-agenda-custom-commands '(("n" "Next 21 days" agenda "" ((org-agenda-span 21)))
("^" "Calfw Month Calendar" th-calfw-open-calendar))
org-return-follows-link t
org-agenda-time-leading-zero t
org-capture-templates '(("n" "NORMAL" entry (file "/home/horn/Repos/org/remember.org")
"* %?\n :PROPERTIES:\n :created: %U\n :link: %a\n :END:\n %i")
("t" "TODO" entry (file "/home/horn/Repos/org/remember.org")
"* TODO %?\n :PROPERTIES:\n :created: %U\n :link: %a\n :END:\n %i")
("i" "IDEA" entry (file "/home/horn/Repos/org/remember.org")
"* IDEA %?\n :PROPERTIES:\n :created: %U\n :link: %a\n :END:\n %i")
)
org-after-todo-state-change-hook '(org-clock-out-if-current)
org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-babel-pre-tangle-hook '(save-buffer)
org-mode-hook '(th-org-mode-init
#[nil "\300\301\302\303\304$\207"
[org-add-hook change-major-mode-hook org-show-block-all append local] 5]
#[nil "\300\301\302\303\304$\207"
[org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
org-refile-targets '((org-agenda-files :maxlevel . 5))
org-attach-method 'mv
org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe)
org-refile-use-outline-path 'file
org-directory "/home/horn/Repos/org"
org-enforce-todo-dependencies t
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
org-cycle-hide-inline-tasks org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-export-latex-format-toc-function 'org-export-latex-format-toc-default
org-export-first-hook '(org-beamer-initialize-open-trackers)
org-agenda-finalize-hook '(th-org-agenda-to-appt)
outline-regexp "\\*+ "
org-attach-directory "/home/horn/Repos/org/attachments"
org-archive-default-command 'org-archive-set-tag
org-refile-allow-creating-parent-nodes 'confirm
org-todo-keywords '((sequence "TODO(t)" "STARTED(s)" "DELEGATED(g)" "IDEA(i)" "|" "DONE(d)"
"CANCELLED(c)")
)
org-modules '(org-icalendar org-attach org-protocol org-id org-bibtex org-docview org-gnus
org-info org-irc org-capture org-mobile)
org-confirm-elisp-link-function 'yes-or-no-p
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-log-into-drawer "LOGBOOK"
org-icalendar-store-UID t
org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
org-mobile-directory "~/Dropbox/MobileOrg"
org-agenda-mode-hook '(th-org-agenda-mode-init)
org-agenda-files '("/home/horn/Repos/org")
org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
org-link-frame-setup '((vm . vm-visit-folder) (gnus . org-gnus-no-new-news)
(file . find-file-other-window))
org-mobile-inbox-for-pull "~/Repos/org/from-org-mobile.org"
org-src-fontify-natively t
)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: Tag inheritance broken in agenda/timeline buffers [7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)]
2013-01-10 7:43 Bug: Tag inheritance broken in agenda/timeline buffers [7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)] Tassilo Horn
@ 2013-01-10 8:33 ` Tassilo Horn
2013-01-10 8:36 ` Tassilo Horn
2013-01-10 10:45 ` Bastien
1 sibling, 1 reply; 5+ messages in thread
From: Tassilo Horn @ 2013-01-10 8:33 UTC (permalink / raw)
To: emacs-orgmode
Tassilo Horn <thorn@fastmail.fm> writes:
> I have (all default values)
>
> org-use-tag-inheritance t
> org-agenda-use-tag-inheritance '(todo search timeline agenda)
> org-agenda-show-inherited-tags t
>
> but there are no inherited tags shown in the agenda or an org-buffer's
> timeline.
>
> When I press `T' on a agenda entry, the inherited tags are properly
> messaged in the echo area, though. I'm sure it used to work, but I'm
> not sure when it stopped working. When I find some time, I can try
> bisecting.
I've done the bisecting:
7684fbd6a227f0ad182661fd7eb17a9e13dc4695 is the first bad commit
commit 7684fbd6a227f0ad182661fd7eb17a9e13dc4695
Author: Nicolas Goaziou <n.goaziou@gmail.com>
Date: Tue Jan 8 10:34:40 2013 +0100
Ignore `auto-fill-inhibit-regexp'
* lisp/org.el (org-setup-filling): Ignore `auto-fill-inhibit-regexp'.
The idea behind this is that `org-adaptive-fill-function' already
determines which lines should be filled.
:040000 040000 a3246c36c59e412bd43df6afa0088d2499268265
7e69342d3b487a61a2cb6bba62b3262896fcdaab M lisp
Now don't ask me how that change affects tag inheritance?!
Bye,
Tassilo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: Tag inheritance broken in agenda/timeline buffers [7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)]
2013-01-10 8:33 ` Tassilo Horn
@ 2013-01-10 8:36 ` Tassilo Horn
2013-01-10 8:55 ` Tassilo Horn
0 siblings, 1 reply; 5+ messages in thread
From: Tassilo Horn @ 2013-01-10 8:36 UTC (permalink / raw)
To: emacs-orgmode
Tassilo Horn <tsdh@gnu.org> writes:
>> When I press `T' on a agenda entry, the inherited tags are properly
>> messaged in the echo area, though. I'm sure it used to work, but I'm
>> not sure when it stopped working. When I find some time, I can try
>> bisecting.
>
> I've done the bisecting:
>
> 7684fbd6a227f0ad182661fd7eb17a9e13dc4695 is the first bad commit
> commit 7684fbd6a227f0ad182661fd7eb17a9e13dc4695
> Author: Nicolas Goaziou <n.goaziou@gmail.com>
> Date: Tue Jan 8 10:34:40 2013 +0100
>
> Ignore `auto-fill-inhibit-regexp'
Sorry for the noise, but I must have done something wrong during
bisect. The previous commit is also "bad", so Nicolas isn't the one to
blame here. I'll bisect again...
Bye,
Tassilo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: Tag inheritance broken in agenda/timeline buffers [7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)]
2013-01-10 8:36 ` Tassilo Horn
@ 2013-01-10 8:55 ` Tassilo Horn
0 siblings, 0 replies; 5+ messages in thread
From: Tassilo Horn @ 2013-01-10 8:55 UTC (permalink / raw)
To: emacs-orgmode
Tassilo Horn <tsdh@gnu.org> writes:
>> I've done the bisecting:
>>
>> 7684fbd6a227f0ad182661fd7eb17a9e13dc4695 is the first bad commit
>> commit 7684fbd6a227f0ad182661fd7eb17a9e13dc4695
>> Author: Nicolas Goaziou <n.goaziou@gmail.com>
>> Date: Tue Jan 8 10:34:40 2013 +0100
>>
>> Ignore `auto-fill-inhibit-regexp'
>
> Sorry for the noise, but I must have done something wrong during
> bisect. The previous commit is also "bad", so Nicolas isn't the one
> to blame here. I'll bisect again...
Ok, here's the new bisecting result, and that seems reasonable:
c8bfd50223d1a75d12d7f74571c24951592c56ec is the first bad commit
commit c8bfd50223d1a75d12d7f74571c24951592c56ec
Author: Bastien Guerry <bzg@altern.org>
Date: Mon Jan 7 16:12:52 2013 +0100
org-agenda.el: New option `org-agenda-use-tag-inheritance'
* org-agenda.el (org-search-view, org-agenda-get-todos)
(org-agenda-get-timestamps, org-agenda-get-sexps)
(org-agenda-get-progress, org-agenda-get-deadlines)
(org-agenda-get-scheduled, org-agenda-get-blocks)
(org-agenda-change-all-lines): Get local tags only.
(org-agenda-use-tag-inheritance): New option.
(org-agenda-finalize): When `org-agenda-use-tag-inheritance'
is non-nil, possibly reset tags in the agenda buffer.
(org-agenda-check-type): Enhance docstring.
See the docstring of the new option for details.
:040000 040000 78b4635191f9aadf4fb1e4aaf4fce5c503e24ef6
cfc6f54ff9328ec0f338f2050b913ae7dfbb399b M lisp
In the diff of that commit, I see a lot of changes like
- (setq tags (org-get-tags-at))
+ (setq tags (org-get-tags-at nil t))
i.e., it used to show all tags (local and inherited), and now it's
explicitly said to display only local tags.
I've validated the result: with c8bfd50223d1a75d12d7f74571c24951592c56ec
tag inheritance is broken, with its predecessor babba02 it does work
again.
Bye,
Tassilo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: Tag inheritance broken in agenda/timeline buffers [7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)]
2013-01-10 7:43 Bug: Tag inheritance broken in agenda/timeline buffers [7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)] Tassilo Horn
2013-01-10 8:33 ` Tassilo Horn
@ 2013-01-10 10:45 ` Bastien
1 sibling, 0 replies; 5+ messages in thread
From: Bastien @ 2013-01-10 10:45 UTC (permalink / raw)
To: Tassilo Horn; +Cc: emacs-orgmode
Hi Tassilo,
Tassilo Horn <thorn@fastmail.fm> writes:
> I have (all default values)
>
> org-use-tag-inheritance t
> org-agenda-use-tag-inheritance '(todo search timeline agenda)
> org-agenda-show-inherited-tags t
>
> but there are no inherited tags shown in the agenda or an org-buffer's
> timeline.
>
> When I press `T' on a agenda entry, the inherited tags are properly
> messaged in the echo area, though.
Yes, I'm aware this change/regression should be fixed, I will fix
it as soon as I have more time.
Thanks,
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-10 10:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-10 7:43 Bug: Tag inheritance broken in agenda/timeline buffers [7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)] Tassilo Horn
2013-01-10 8:33 ` Tassilo Horn
2013-01-10 8:36 ` Tassilo Horn
2013-01-10 8:55 ` Tassilo Horn
2013-01-10 10:45 ` Bastien
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.