From: Nathan Trapuzzano <nbtrap@nbtrap.com>
To: 13446@debbugs.gnu.org
Subject: bug#13446: 24.2; Fix loop test in linum.el
Date: Mon, 14 Jan 2013 20:13:13 -0500 [thread overview]
Message-ID: <87y5fvp7ti.fsf@nbtrap.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
There is an incorrect loop test in linum.el that potentially applies an
overlay to a line not visible in the window and thereby messes up the
width of the overlays in the lines that are visible. The patch/merge
directive is attached, and what follows is the commit message:
-----
Modify loop test in `linum-update-window'.
`limit' is set to the position returned by `window-end'; this position
is either on the last visible (logical) line in the buffer or is the
first position on the line following the last visible line. In the
former case, the loop variable never reaches the value of `limit', but
in the latter case, an overlay is applied to a line that is not
visible in the window. This can mess up the width of the overlay on
the visible lines, especially if the width of the line number (as a
string) of the line that's not visible is different from the width of
the visible lines' line numbers.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: linum.patch --]
[-- Type: text/x-patch, Size: 1105 bytes --]
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: nbtrap@nbtrap.com-20130115010121-h7kwjyr5kimowgml
# target_branch: .
# testament_sha1: a9154d3ede2b389220646bb8e9e708117d876d01
# timestamp: 2013-01-14 20:03:26 -0500
# base_revision_id: nbtrap@nbtrap.com-20130111013646-pn4xh5r94x5asomb
#
# Begin patch
=== modified file 'lisp/linum.el'
--- lisp/linum.el 2012-01-19 07:21:25 +0000
+++ lisp/linum.el 2013-01-15 00:45:27 +0000
@@ -151,7 +151,7 @@
(run-hooks 'linum-before-numbering-hook)
;; Create an overlay (or reuse an existing one) for each
;; line visible in this window, if necessary.
- (while (and (not (eobp)) (<= (point) limit))
+ (while (and (not (eobp)) (< (point) limit))
(let* ((str (if fmt
(propertize (format fmt line) 'face 'linum)
(funcall linum-format line)))
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWdjgvvgAABJfgAAQQGFxUBIA
AACv794QIABkRTaajamQyGjTaRiFGgBMBBkwQhDmaVnH5r9hMFQyJ7EUzThiw4Ixc/mQVpexbPS2
9yLLTxaFbWvXcN2zcydOQxpD652acQC4g4Z96jI5BipgKAAiM5Zz45Kd/4u5IpwoSGxwX3wA
next reply other threads:[~2013-01-15 1:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 1:13 Nathan Trapuzzano [this message]
2013-10-25 15:26 ` bug#13446: 24.2; Fix loop test in linum.el Nathan Trapuzzano
2013-10-27 4:20 ` Stefan Monnier
2013-10-27 11:54 ` Nathan Trapuzzano
2013-10-27 13:39 ` Stefan Monnier
2013-10-27 19:36 ` Nathan Trapuzzano
2013-10-28 0:36 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2013-01-15 5:36 bug#13454: 24.2; Small fix to reference manual Nathan Trapuzzano
2013-10-26 21:44 ` bug#13446: 24.2; Fix loop test in linum.el Nathan Trapuzzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5fvp7ti.fsf@nbtrap.com \
--to=nbtrap@nbtrap.com \
--cc=13446@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.