From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Llu=C3=ADs?= Vilanova Newsgroups: gmane.emacs.bugs Subject: bug#14168: 24.3.50; vc: Incorrect 'vc-bzr-print-log' when 'start-revision' and 'limit' are set Date: Sun, 21 Apr 2013 20:57:05 +0200 Message-ID: <87y5cblnjy.fsf@fimbulvetr.bsc.es> References: <87a9p7v7hs.fsf@fimbulvetr.bsc.es> <83ppy3a3r6.fsf@gnu.org> <87txnfpjpd.fsf@fimbulvetr.bsc.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1366570697 767 80.91.229.3 (21 Apr 2013 18:58:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Apr 2013 18:58:17 +0000 (UTC) Cc: 14168@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 21 20:58:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UTzSv-0002uD-Es for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Apr 2013 20:58:21 +0200 Original-Received: from localhost ([::1]:36714 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTzSv-0002tR-5l for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Apr 2013 14:58:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTzSr-0002rH-0R for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2013 14:58:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTzSp-000557-Rg for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2013 14:58:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTzSp-00054v-M4 for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2013 14:58:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UTzXR-0002n7-Q9 for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2013 15:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Llu=C3=ADs?= Vilanova Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Apr 2013 19:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14168 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14168-submit@debbugs.gnu.org id=B14168.136657092710594 (code B ref 14168); Sun, 21 Apr 2013 19:03:01 +0000 Original-Received: (at 14168) by debbugs.gnu.org; 21 Apr 2013 19:02:07 +0000 Original-Received: from localhost ([127.0.0.1]:35759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UTzWV-0002kl-If for submit@debbugs.gnu.org; Sun, 21 Apr 2013 15:02:07 -0400 Original-Received: from roura.ac.upc.es ([147.83.33.10]:37357) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UTzWM-0002jy-SU for 14168@debbugs.gnu.org; Sun, 21 Apr 2013 15:01:56 -0400 Original-Received: from gw.ac.upc.edu (gw.ac.upc.es [147.83.30.3]) by roura.ac.upc.es (8.13.8/8.13.8) with ESMTP id r3LIv53K001462; Sun, 21 Apr 2013 20:57:06 +0200 Original-Received: from localhost (unknown [84.88.51.85]) by gw.ac.upc.edu (Postfix) with ESMTP id 8694F6B01A4; Sun, 21 Apr 2013 20:57:05 +0200 (CEST) In-Reply-To: (Glenn Morris's message of "Sat, 20 Apr 2013 22:35:54 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73561 Archived-At: Glenn Morris writes: > Llu=C3=ADs Vilanova wrote: >>> Are you sure this isn't a confusion about what is meant by "starting >>> from the revision"? >>=20 >> Might well be. I understand it as "from given revision to newest >> revision". > This area is confusing. It is not well documented and inconsistently > implemented. The only documentation we have is in the commentary of > vc.el: [...] > In practice, the only place in Emacs that uses this is > vc-annotate-show-log-revision-at-line, which shows a single revision > only. So we have no way to tell what the intended behaviour is when > LIMIT !=3D 1. > We should either document that it only works for LIMIT =3D 1, or decide > what it is supposed to do and make it consistent. > I'm guessing that START was supposed to be the newest revision, which is > the opposite of what I (like you) first thought. > I have no idea how to sensibly combine this with someone having "bzr log" > aliased to "bzr log --forward". > bzr log --forward -r ..3 --limit 2=20 > will display revisions 1 and 2 rather than 2 and 3. There doesn't seem > to be a simple way to get the latter. > https://lists.ubuntu.com/archives/bazaar/2007q4/035828.html > You are correct that the --limit option does not make much sense with > the --forward option. It is not meant to. > https://bugs.launchpad.net/bzr/+bug/320920 > I don't know if we should bother trying to figure it out given that the > only caller of this uses LIMIT =3D=3D 1. I'd probably just stick a > --no-aliases in there. Nice, I didn't know about the "--no-aliases" argument, and that might prove useful. As a side note, I sent a small patch for the case where LIMIT is 1. Looking at the code, I'd rather rename START-REVISION as REVISION, which I = think would be less confusing given the current semantics. Lluis