From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: 14168@debbugs.gnu.org
Subject: bug#14168: 24.3.50; vc: Incorrect 'vc-bzr-print-log' when 'start-revision' and 'limit' are set
Date: Sun, 21 Apr 2013 20:57:05 +0200 [thread overview]
Message-ID: <87y5cblnjy.fsf@fimbulvetr.bsc.es> (raw)
In-Reply-To: <c4r4i4fw51.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sat, 20 Apr 2013 22:35:54 -0400")
Glenn Morris writes:
> Lluís Vilanova wrote:
>>> Are you sure this isn't a confusion about what is meant by "starting
>>> from the revision"?
>>
>> Might well be. I understand it as "from given revision to newest
>> revision".
> This area is confusing. It is not well documented and inconsistently
> implemented. The only documentation we have is in the commentary of
> vc.el:
[...]
> In practice, the only place in Emacs that uses this is
> vc-annotate-show-log-revision-at-line, which shows a single revision
> only. So we have no way to tell what the intended behaviour is when
> LIMIT != 1.
> We should either document that it only works for LIMIT = 1, or decide
> what it is supposed to do and make it consistent.
> I'm guessing that START was supposed to be the newest revision, which is
> the opposite of what I (like you) first thought.
> I have no idea how to sensibly combine this with someone having "bzr log"
> aliased to "bzr log --forward".
> bzr log --forward -r ..3 --limit 2
> will display revisions 1 and 2 rather than 2 and 3. There doesn't seem
> to be a simple way to get the latter.
> https://lists.ubuntu.com/archives/bazaar/2007q4/035828.html
> You are correct that the --limit option does not make much sense with
> the --forward option. It is not meant to.
> https://bugs.launchpad.net/bzr/+bug/320920
> I don't know if we should bother trying to figure it out given that the
> only caller of this uses LIMIT == 1. I'd probably just stick a
> --no-aliases in there.
Nice, I didn't know about the "--no-aliases" argument, and that might prove
useful. As a side note, I sent a small patch for the case where LIMIT is 1.
Looking at the code, I'd rather rename START-REVISION as REVISION, which I think
would be less confusing given the current semantics.
Lluis
next prev parent reply other threads:[~2013-04-21 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 19:17 bug#14168: 24.3.50; vc: Incorrect 'vc-bzr-print-log' when 'start-revision' and 'limit' are set Lluís Vilanova
2013-04-09 19:43 ` Eli Zaretskii
2013-04-09 19:50 ` Lluís Vilanova
2013-04-21 2:35 ` Glenn Morris
2013-04-21 18:57 ` Lluís Vilanova [this message]
2013-04-24 8:14 ` Glenn Morris
[not found] ` <handler.14168.B.136553563617274.ack@debbugs.gnu.org>
2013-04-09 19:47 ` bug#14168: vc: [bzr] Properly limit revisions in 'vc-bzr-print-log' Lluís Vilanova
[not found] ` <handler.14168.D14168.136679158415888.notifdone@debbugs.gnu.org>
2013-04-24 12:58 ` bug#14168: closed (Re: bug#14168: 24.3.50; vc: Incorrect 'vc-bzr-print-log' when 'start-revision' and 'limit' are set) Lluís Vilanova
2013-04-24 16:41 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5cblnjy.fsf@fimbulvetr.bsc.es \
--to=vilanova@ac.upc.edu \
--cc=14168@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.