[PATCH] * lisp/progmodes/ruby-mode.el: Remove some obsolete code.

[PATCH] * lisp/progmodes/ruby-mode.el: Remove some obsolete code.

[Bozhidar Batsov]

[-- Attachment #1.1: Type: text/plain, Size: 235 bytes --]

Hi guys,  

I’ve removed a few lines of code from ruby-mode.el (namely explicit setting of a syntax table and an abbrev table), that as far as I know are obsolete when using `define-derived-mode’.  

--  
Cheers,
Bozhidar


[-- Attachment #1.2: Type: text/html, Size: 519 bytes --]

[-- Attachment #2: 0001-lisp-progmodes-ruby-mode.el-Remove-some-obsolete-cod.patch --]
[-- Type: application/octet-stream, Size: 1195 bytes --]

From c2df79b976bbeb9db1f695884ef82fcfda53e5e0 Mon Sep 17 00:00:00 2001
From: Bozhidar Batsov <bozhidar@batsov.com>
Date: Fri, 1 Nov 2013 14:47:37 +0200
Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Remove some obsolete code.

---
 lisp/progmodes/ruby-mode.el | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/lisp/progmodes/ruby-mode.el b/lisp/progmodes/ruby-mode.el
index 1a49f70..db78d33 100644
--- a/lisp/progmodes/ruby-mode.el
+++ b/lisp/progmodes/ruby-mode.el
@@ -141,9 +141,6 @@ This should only be called after matching against `ruby-here-doc-beg-re'."
 (defconst ruby-symbol-re (concat "[" ruby-symbol-chars "]")
   "Regexp to match symbols.")
 
-(define-abbrev-table 'ruby-mode-abbrev-table ()
-  "Abbrev table in use in Ruby mode buffers.")
-
 (defvar ruby-use-smie t)
 
 (defvar ruby-mode-map
@@ -563,8 +560,6 @@ explicitly declared in magic comment."
 
 (defun ruby-mode-variables ()
   "Set up initial buffer-local variables for Ruby mode."
-  (set-syntax-table ruby-mode-syntax-table)
-  (setq local-abbrev-table ruby-mode-abbrev-table)
   (setq indent-tabs-mode ruby-indent-tabs-mode)
   (if ruby-use-smie
       (smie-setup ruby-smie-grammar #'ruby-smie-rules
-- 
1.8.4

Re: [PATCH] * lisp/progmodes/ruby-mode.el: Remove some obsolete code.

[Dmitry Gutov]

Bozhidar Batsov <bozhidar.batsov@gmail.com> writes:

> I’ve removed a few lines of code from ruby-mode.el (namely explicit setting of a syntax table and
> an abbrev table), that as far as I know are obsolete when using
> `define-derived-mode’.

Installed, thanks.