From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Date: Tue, 10 Dec 2013 21:07:25 +0100 Message-ID: <87y53sjwqq.fsf@thinkpad.tsdh.org> References: <87a9gbb7wi.fsf@hochschule-trier.de> <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> <877gbcfxvy.fsf@hochschule-trier.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386706093 27649 80.91.229.3 (10 Dec 2013 20:08:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Dec 2013 20:08:13 +0000 (UTC) Cc: 16090@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 10 21:08:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VqTbN-00058p-4b for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Dec 2013 21:08:17 +0100 Original-Received: from localhost ([::1]:51133 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqTbM-0002gG-MK for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Dec 2013 15:08:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqTbE-0002eD-2x for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 15:08:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqTb8-0007e9-KB for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 15:08:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqTb8-0007dl-E8 for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 15:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VqTb7-0007Dd-VL for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 15:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Dec 2013 20:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16090 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16090-submit@debbugs.gnu.org id=B16090.138670605727715 (code B ref 16090); Tue, 10 Dec 2013 20:08:01 +0000 Original-Received: (at 16090) by debbugs.gnu.org; 10 Dec 2013 20:07:37 +0000 Original-Received: from localhost ([127.0.0.1]:42183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqTai-0007Cx-FN for submit@debbugs.gnu.org; Tue, 10 Dec 2013 15:07:36 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:51315) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqTaf-0007Ck-01 for 16090@debbugs.gnu.org; Tue, 10 Dec 2013 15:07:34 -0500 Original-Received: from compute6.internal (compute6.nyi.mail.srv.osa [10.202.2.46]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 665BD2269A for <16090@debbugs.gnu.org>; Tue, 10 Dec 2013 15:07:27 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Tue, 10 Dec 2013 15:07:29 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=P62UbWbhxxrPyGYViRZDDEroGT0=; b=SS0i82DVEQQEUdzJ2RlBEnHEZEjH BPMa60cEzQ7NUyl9JrNFjiEzed4YGT6iC70JcnFEuTT+ukhfzuC06BQ/SRlJitJM kvQ4hMhpMR5TeItC1RHWiGhRlBXZANY0nRMvl4JZX5rEAiG/MoQcSbuGZsxSrJDI s0xfy+EOrc9cmN0= X-Sasl-enc: GVAf7qbmLlL8YnGPMvaQq6XtwUee52/owVcZpgXUda1j 1386706047 Original-Received: from thinkpad.tsdh.org (unknown [91.67.164.26]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F192C00E9D; Tue, 10 Dec 2013 15:07:27 -0500 (EST) In-Reply-To: <877gbcfxvy.fsf@hochschule-trier.de> (Andreas Politz's message of "Tue, 10 Dec 2013 17:56:17 +0100") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81709 Archived-At: Andreas Politz writes: >>> The code is already equipped to handle non-displayed buffers (it >>> keeps track of the "default current page" which is later used >>> when/if the buffer gets displayed in a window). > > Where is this page read and gone to ? doc-view-new-window-function at > most switches to the first page Comment in the `message' in the first line. You'll see that it's called two times (once with t and once with a window in (car winprops)) if the buffer hasn't been shown in some window already. > and this > > (with-current-buffer (find-file-noselect "some.pdf") > (doc-view-goto-page 2) > (pop-to-buffer (current-buffer))) > > also displays the first page. No, if some.pdf hasn't been open yet, it'll show page 2. In that case, `image-mode-winprops-alist' default entry will look like this: (t (info . #("Page 2 of 6.\n" 0 12 (face bold))) (page . 2) (overlay . #)) > Is this a mistake in this function, i.e. shouldn't it read the winprop > page? That happens during the second time the function is called with a real window by making the overlay showing the image with that window's page visible. Bye, Tassilo