From: Tassilo Horn <tsdh@gnu.org>
To: Andreas Politz <politza@hochschule-trier.de>
Cc: 16090@debbugs.gnu.org
Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark
Date: Tue, 10 Dec 2013 21:07:25 +0100 [thread overview]
Message-ID: <87y53sjwqq.fsf@thinkpad.tsdh.org> (raw)
In-Reply-To: <877gbcfxvy.fsf@hochschule-trier.de> (Andreas Politz's message of "Tue, 10 Dec 2013 17:56:17 +0100")
Andreas Politz <politza@hochschule-trier.de> writes:
>>> The code is already equipped to handle non-displayed buffers (it
>>> keeps track of the "default current page" which is later used
>>> when/if the buffer gets displayed in a window).
>
> Where is this page read and gone to ? doc-view-new-window-function at
> most switches to the first page
Comment in the `message' in the first line. You'll see that it's called
two times (once with t and once with a window in (car winprops)) if the
buffer hasn't been shown in some window already.
> and this
>
> (with-current-buffer (find-file-noselect "some.pdf")
> (doc-view-goto-page 2)
> (pop-to-buffer (current-buffer)))
>
> also displays the first page.
No, if some.pdf hasn't been open yet, it'll show page 2. In that case,
`image-mode-winprops-alist' default entry will look like this:
(t
(info .
#("Page 2 of 6.\n" 0 12
(face bold)))
(page . 2)
(overlay . #<overlay in no buffer>))
> Is this a mistake in this function, i.e. shouldn't it read the winprop
> page?
That happens during the second time the function is called with a real
window by making the overlay showing the image with that window's page
visible.
Bye,
Tassilo
next prev parent reply other threads:[~2013-12-10 20:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-08 16:54 bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Andreas Politz
2013-12-09 9:13 ` Tassilo Horn
2013-12-09 12:33 ` Andreas Politz
2013-12-09 14:56 ` Tassilo Horn
2013-12-09 16:55 ` Glenn Morris
2013-12-10 7:28 ` Tassilo Horn
2013-12-10 2:51 ` Stefan Monnier
2013-12-10 7:53 ` Tassilo Horn
2013-12-10 10:02 ` Andreas Politz
2013-12-10 11:58 ` Andreas Politz
2013-12-10 16:56 ` Andreas Politz
2013-12-10 20:07 ` Tassilo Horn [this message]
2013-12-10 22:16 ` Andreas Politz
2013-12-11 4:43 ` Stefan Monnier
2013-12-11 19:08 ` Tassilo Horn
2013-12-20 8:00 ` Tassilo Horn
2013-12-20 8:28 ` Andreas Politz
2013-12-20 13:02 ` Tassilo Horn
2014-04-02 14:43 ` Stefan Monnier
2014-04-04 13:43 ` Tassilo Horn
2014-04-04 15:14 ` Stefan Monnier
2014-04-04 15:53 ` Tassilo Horn
2014-04-04 16:04 ` Glenn Morris
2014-04-04 17:44 ` Tassilo Horn
2013-12-20 14:33 ` Stefan Monnier
2013-12-20 14:36 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y53sjwqq.fsf@thinkpad.tsdh.org \
--to=tsdh@gnu.org \
--cc=16090@debbugs.gnu.org \
--cc=politza@hochschule-trier.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.