bug#5727: 23.1.92; Clicking size-indicator-mode indicator gives wrong menu

bug#5727: 23.1.92; Clicking size-indicator-mode indicator gives wrong menu

[Drew Adams]

emacs -Q

In GNU Emacs 23.1.92.1 (i386-mingw-nt5.1.2600)
 of 2010-02-20 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'

Click the size-indicator-mode indicator (e.g `Top') in the mode line. The menu
shown is wrong - it is the same menu as is shown when you click the line or
column number.

It should instead have the menu item `Toggle Size Indicator Mode'.

If the aim was to have some way to turn on line and column number display when
these are both off, then you might add those menu items to the one above (to
toggle size indicator mode). 

But even then this is the wrong approach. You should not click Peter to modify
Paul.

bug#5727: 23.1.92; Clicking size-indicator-mode indicator gives wrong menu

[Lars Ingebrigtsen]

"Drew Adams" <drew.adams@oracle.com> writes:

> Click the size-indicator-mode indicator (e.g `Top') in the mode line. The menu
> shown is wrong - it is the same menu as is shown when you click the line or
> column number.
>
> It should instead have the menu item `Toggle Size Indicator Mode'.
>
> If the aim was to have some way to turn on line and column number display when
> these are both off, then you might add those menu items to the one above (to
> toggle size indicator mode). 
>
> But even then this is the wrong approach. You should not click Peter to modify
> Paul.

I guess.  But, on the other hand, it's nice to be able to get the line
numbers back if you've removed them.  Perhaps that's the reason it was
done this way?

I agree that the current mode bare menus are confused.  And I would be
surprised if anybody ever used them.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#5727: 23.1.92; Clicking size-indicator-mode indicator gives wrong menu

[Lars Ingebrigtsen]

"Drew Adams" <drew.adams@oracle.com> writes:

> Click the size-indicator-mode indicator (e.g `Top') in the mode line. The menu
> shown is wrong - it is the same menu as is shown when you click the line or
> column number.
>
> It should instead have the menu item `Toggle Size Indicator Mode'.
>
> If the aim was to have some way to turn on line and column number display when
> these are both off, then you might add those menu items to the one above (to
> toggle size indicator mode). 
>
> But even then this is the wrong approach. You should not click Peter to modify
> Paul.

I think it's fine to have that menu on "Top", too, because you can't get
the modes back on again otherwise.  But perhaps `size-indication-mode'
should also be in `mode-line-column-line-number-mode-map'?  Any objections?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#5727: 23.1.92; Clicking size-indicator-mode indicator gives wrong menu

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I think it's fine to have that menu on "Top", too, because you can't get
> the modes back on again otherwise.  But perhaps `size-indication-mode'
> should also be in `mode-line-column-line-number-mode-map'?  Any objections?

I've now added it to the menu.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no