From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.help Subject: Re: replacing a function with another one Date: Wed, 12 Mar 2014 00:51:55 +0100 Message-ID: <87y50gs38k.fsf@web.de> References: <87vbvofsi6.fsf@yun.yagibdah.de> <87bnxgs4r9.fsf@web.de> <87lhwj1cfz.fsf@yun.yagibdah.de> <87zjkz6vd5.fsf@web.de> <8738ir161u.fsf@yun.yagibdah.de> <87eh2b6nfm.fsf@web.de> <87r46anab5.fsf@yun.yagibdah.de> <87vbvleiey.fsf@yun.yagibdah.de> <87vbvlbm8p.fsf@web.de> <87siqpsdgs.fsf@yun.yagibdah.de> <87ob1djpkq.fsf@web.de> <87txb4izhj.fsf@yun.yagibdah.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1394581949 29155 80.91.229.3 (11 Mar 2014 23:52:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Mar 2014 23:52:29 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Wed Mar 12 00:52:38 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WNWTN-00081h-V8 for geh-help-gnu-emacs@m.gmane.org; Wed, 12 Mar 2014 00:52:38 +0100 Original-Received: from localhost ([::1]:57943 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNWTN-0007j3-Df for geh-help-gnu-emacs@m.gmane.org; Tue, 11 Mar 2014 19:52:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNWT5-0006mk-BU for help-gnu-emacs@gnu.org; Tue, 11 Mar 2014 19:52:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNWSy-0005Nx-SD for help-gnu-emacs@gnu.org; Tue, 11 Mar 2014 19:52:19 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:54726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNWSy-0005Nk-LL for help-gnu-emacs@gnu.org; Tue, 11 Mar 2014 19:52:12 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WNWSx-0007h0-31 for help-gnu-emacs@gnu.org; Wed, 12 Mar 2014 00:52:11 +0100 Original-Received: from ip-90-187-149-152.web.vodafone.de ([90.187.149.152]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Mar 2014 00:52:11 +0100 Original-Received: from michael_heerdegen by ip-90-187-149-152.web.vodafone.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Mar 2014 00:52:11 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 35 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: ip-90-187-149-152.web.vodafone.de User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:urvK+0NeW1336qz3xUA0Y1uFmek= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:96437 Archived-At: lee writes: > The idea is very simple: When patterns are to be read from another > buffer, switch to that buffer before they are being read. Before > applying them, switch back to the original buffer. > > I can´t do that with `with-current-buffer´ because two different functions > need to be advised to do it, and I can´t get add-advice to work with > :around. > > Why shouldn´t I switch buffers? They are switched back anyway. But what the code that's being run in the meantime, between your advices? Then, the wrong buffer is current. That can't work. > One thing I haven´t been able to figure out is how hi-lock.el decides > what the lines it writes to the buffer are prepended with. In one > buffer, it puts "// Hi-lock ...", in another one, it´s "# Hi-lock ...". > Then it searches patterns with '"\\<" hi-lock-file-patterns-prefix ":"', > and apparently it will not find patterns prepended with "//" when it > figures that they should be prepended with "#". When writing the specification to he buffer, it calls `comment-region', which DTRT in any mode. `hi-lock-find-patterns' indeed doesn't seem to search only inside comments, it just searches the whole buffer for the regexp (concat "\\<" hi-lock-file-patterns-prefix ":") Regards, Michael.