From: Alexis <flexibeast@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Possible bug in `match-string` in 24.4.50.18?
Date: Mon, 26 May 2014 10:22:58 +1000 [thread overview]
Message-ID: <87y4xpfkwt.fsf@gmail.com> (raw)
In-Reply-To: <jwviooty6gj.fsf-monnier+emacs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Take the following code:
>
>> (setq address "mailto:alexis@example.com")
>> (setq re "mailto")
>> (string-match re address)
>> (match-string 0 address)
>
> These are 4 separate expressions. How do you run them?
i was playing around in *scratch*, to test out various regular
expressions on my data, and did a C-x C-e after each line. The above was
the result of whittling down the problem to the simplest case i could
find that exhibited the problem. There was nothing else in the buffer,
and as i noted to Eli, i was indeed running with the -Q option.
> My crystal ball says that the problem is the code you unknowingly run
> between each one of those expressions. If you run them as a single
> expression such as
>
> (let ((address "mailto:alexis@example.com")
> (re "mailto"))
> (if (string-match re address)
> (match-string 0 address)))
>
> I'm pretty sure you'll get what you want.
It seems you're right. :-) Thank you!
i now note that this situation is indeed described in the GNU Emacs Lisp
Reference Manual:
"Notice that all functions are allowed to overwrite the match data
unless they're explicitly documented not to do so. A consequence is that
functions that are run implicitly in the background (see Timers, and
Idle Timers) should likely save and restore the match data explicitly."
.... which i hadn't read because i'd only been reading section "34.6.2
Simple Match Data Access":
"Every successful search sets the match data. Therefore, you should
query the match data immediately after searching, before calling any
other function that might perform another search."
.... which is what i thought my code was doing.
Since the latter text is from a reference manual which, i suspect, other
people will often use by simply reading specific function documentation,
could i suggest adding to the latter text something along the lines of:
"Note that all functions are allowed to overwrite the match data unless
they're explicitly documented not to do so. A consequence is that
functions that are run implicitly in the background might overwrite your
match data unless you wrap your matching function (e.g. string-match)
and match-string together in a let."
Thanks again!
Alexis.
next prev parent reply other threads:[~2014-05-26 0:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 4:33 Possible bug in `match-string` in 24.4.50.18? Alexis
2014-05-25 13:35 ` Eli Zaretskii
2014-05-26 0:01 ` Alexis
2014-05-25 20:02 ` Stefan Monnier
2014-05-26 0:22 ` Alexis [this message]
2014-05-26 17:45 ` Stefan Monnier
2014-05-26 18:54 ` David Kastrup
2014-05-27 8:20 ` Alexis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4xpfkwt.fsf@gmail.com \
--to=flexibeast@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.