From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 17554@debbugs.gnu.org, Roland Winkler <winkler@gnu.org>
Subject: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window
Date: Tue, 17 Jun 2014 09:44:19 +0300 [thread overview]
Message-ID: <87y4wwujb0.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvha3ksf2c.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Mon, 16 Jun 2014 17:47:42 -0400")
>> We need two temp buffers like *Marked files* (small) and
>> *Completions* (bigger) for this bug to show up.
>
> FWIW, I think the right way to handle this case is to mark the window
> displaying *Marked files* as "dedicated".
This is achieved in this patch by binding `display-buffer-mark-dedicated'
to the same value 'soft' as in `minibuffer-completion-help' used
to display *Completions*.
Also I noticed that everywhere in code only `soft' is used instead of `softly'
that is suggested in window.el, so documentation could be fixed as well.
=== modified file 'lisp/dired.el'
--- lisp/dired.el 2014-05-08 19:22:43 +0000
+++ lisp/dired.el 2014-06-17 06:42:52 +0000
@@ -3099,7 +3099,10 @@ (defun dired-mark-pop-up (buffer-or-name
;; If FILES defaulted to the current line's file.
(= (length files) 1))
(apply function args)
- (let ((buffer (get-buffer-create (or buffer-or-name " *Marked Files*"))))
+ (let ((buffer (get-buffer-create (or buffer-or-name " *Marked Files*")))
+ ;; Mark *Marked Files* as softly-dedicated, to prevent other
+ ;; new windows e.g. *Completions* from reusing it (bug#17554).
+ (display-buffer-mark-dedicated 'soft))
(with-current-buffer buffer
(with-current-buffer-window
buffer
=== modified file 'lisp/window.el'
--- lisp/window.el 2014-06-03 12:38:17 +0000
+++ lisp/window.el 2014-06-17 06:42:19 +0000
@@ -5966,7 +5966,7 @@ (defun window--maybe-raise-frame (frame)
;; FIXME: By the way, there could be more levels of dedication:
;; - `barely' dedicated doesn't prevent reuse of the window, only records that
;; the window hasn't been used for something else yet.
-;; - `softly' dedicated only allows reuse when asked explicitly.
+;; - `soft' dedicated only allows reuse when asked explicitly.
;; - `strongly' never allows reuse.
(defvar display-buffer-mark-dedicated nil
"If non-nil, `display-buffer' marks the windows it creates as dedicated.
next prev parent reply other threads:[~2014-06-17 6:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 19:59 bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Roland Winkler
2014-05-23 1:07 ` Stefan Monnier
2014-05-23 2:17 ` Roland Winkler
2014-05-23 6:06 ` Eli Zaretskii
2014-05-23 7:24 ` martin rudalics
2014-05-23 21:32 ` Juri Linkov
2014-05-27 21:54 ` Juri Linkov
2014-05-27 22:45 ` Roland Winkler
2014-06-05 23:48 ` Juri Linkov
2014-06-06 1:07 ` Stefan Monnier
2014-06-06 4:17 ` Roland Winkler
2014-06-06 23:05 ` Juri Linkov
2014-06-09 16:15 ` Roland Winkler
2014-06-10 0:12 ` Juri Linkov
2014-06-10 6:07 ` martin rudalics
2014-06-10 22:57 ` Juri Linkov
2014-06-11 7:15 ` martin rudalics
2014-06-12 6:33 ` Juri Linkov
2014-06-16 6:51 ` Juri Linkov
2014-06-16 19:49 ` Roland Winkler
2014-06-16 21:47 ` Stefan Monnier
2014-06-17 6:44 ` Juri Linkov [this message]
2014-06-18 7:57 ` Juri Linkov
2014-06-06 23:04 ` Juri Linkov
2014-06-18 8:07 ` Juri Linkov
2014-05-23 5:48 ` Eli Zaretskii
2014-05-23 7:25 ` martin rudalics
2014-05-23 7:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4wwujb0.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=17554@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.