From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#18048: 24.3.92; [patch] eldoc improvements Date: Mon, 21 Jul 2014 09:24:50 +0200 Message-ID: <87y4vn2mu6.fsf@gmail.com> References: <87egxjxkxh.fsf@gmail.com> <8738dx6a0g.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1405927706 9996 80.91.229.3 (21 Jul 2014 07:28:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Jul 2014 07:28:26 +0000 (UTC) Cc: 18048@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 21 09:28:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X981D-0003Mn-38 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Jul 2014 09:28:19 +0200 Original-Received: from localhost ([::1]:60998 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X981C-0006KS-E5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Jul 2014 03:28:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9813-0006JR-6t for bug-gnu-emacs@gnu.org; Mon, 21 Jul 2014 03:28:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X980x-0000nY-8w for bug-gnu-emacs@gnu.org; Mon, 21 Jul 2014 03:28:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X980x-0000nT-5C for bug-gnu-emacs@gnu.org; Mon, 21 Jul 2014 03:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X980w-00044S-IR for bug-gnu-emacs@gnu.org; Mon, 21 Jul 2014 03:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Jul 2014 07:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18048-submit@debbugs.gnu.org id=B18048.140592766915621 (code B ref 18048); Mon, 21 Jul 2014 07:28:02 +0000 Original-Received: (at 18048) by debbugs.gnu.org; 21 Jul 2014 07:27:49 +0000 Original-Received: from localhost ([127.0.0.1]:60979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X980i-00043r-Na for submit@debbugs.gnu.org; Mon, 21 Jul 2014 03:27:49 -0400 Original-Received: from mail-we0-f171.google.com ([74.125.82.171]:58475) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X980g-00043W-6A for 18048@debbugs.gnu.org; Mon, 21 Jul 2014 03:27:46 -0400 Original-Received: by mail-we0-f171.google.com with SMTP id p10so7178098wes.16 for <18048@debbugs.gnu.org>; Mon, 21 Jul 2014 00:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:to:cc:subject:date:in-reply-to:message-id :mime-version:content-type; bh=AGUtIER9wQQYQmgsDURw2AF4cZwcWGwkjgAyOcuneYo=; b=hHzK70obf037BcUE6lqDjU/p8CbRMr6Io2OB0SQKh2vQpcObdRfjYBNH6FV1hjK3pr 9kmWFnSqfegqa5QoiFdsFIoZ3+VK1mbnqmOy9C2T2Dn4zXWYQ7ZIrUGwGoD6P8gfCVQM vIQ/3jGtrLx+xkU953IDl55mEDGZeSwo98nIvhnIv6DoZsvzgNFmH44I0OywfCA1YHR+ 5voWtC3fQb9OWvM21Vg1geeGGZDO5FgEghCbeW1eBsjWfMvnfrFlNsqWQkY9M2hMFeCq y7tPGwlQ0gfUy5VZQ/B/fodKSE0MMv/evnh9N4qEypTIpVVZa77fEFpr6yNBPmnt8too 2oHA== X-Received: by 10.194.23.135 with SMTP id m7mr20031483wjf.2.1405927660384; Mon, 21 Jul 2014 00:27:40 -0700 (PDT) Original-Received: from dell-14z ([37.162.61.122]) by mx.google.com with ESMTPSA id fs3sm38827571wic.20.2014.07.21.00.27.38 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 21 Jul 2014 00:27:39 -0700 (PDT) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91720 Archived-At: Stefan Monnier writes: >> Also the words &key and &allow-other-keys are upcased. > > Hmm... this eldoc code reminds me of similar code in help-fns.el. > Can you take a look at it and see if we could consolidate them? I didn't find in help-fns.el, but in help.el I found `help-function-arglist' which is used by eldoc. diff --git a/lisp/help.el b/lisp/help.el index fa2a4f2..8bd5fd0 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -1294,7 +1294,7 @@ the same names as used in the original source code, when possible." (unless (and (symbolp arg) (let ((name (symbol-name arg))) (if (eq (aref name 0) ?&) - (memq arg '(&rest &optional)) + (memq arg '(&rest &optional &key &allow-other-keys)) (not (string-match "\\." name))))) (setq valid nil))) (when valid arglist))) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997