From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#19127: 25.0.50; [PATCH] * net/eww.el (eww-add-bookmark): Fix bookmark title Date: Thu, 20 Nov 2014 12:49:28 -0500 Message-ID: <87y4r5ep93.fsf@udel.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416505826 27142 80.91.229.3 (20 Nov 2014 17:50:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Nov 2014 17:50:26 +0000 (UTC) To: 19127@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 20 18:50:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrVs2-0001Q9-68 for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Nov 2014 18:50:18 +0100 Original-Received: from localhost ([::1]:36720 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrVs1-0005bK-RN for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Nov 2014 12:50:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrVrt-0005YE-Kh for bug-gnu-emacs@gnu.org; Thu, 20 Nov 2014 12:50:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrVrn-0001Gm-6T for bug-gnu-emacs@gnu.org; Thu, 20 Nov 2014 12:50:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrVrn-0001GV-2P for bug-gnu-emacs@gnu.org; Thu, 20 Nov 2014 12:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XrVrm-0004i7-Op for bug-gnu-emacs@gnu.org; Thu, 20 Nov 2014 12:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Nov 2014 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19127 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.141650579118082 (code B ref -1); Thu, 20 Nov 2014 17:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Nov 2014 17:49:51 +0000 Original-Received: from localhost ([127.0.0.1]:39778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrVrb-0004ha-1Q for submit@debbugs.gnu.org; Thu, 20 Nov 2014 12:49:51 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43016) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrVrZ-0004hS-2e for submit@debbugs.gnu.org; Thu, 20 Nov 2014 12:49:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrVrS-00018F-Gj for submit@debbugs.gnu.org; Thu, 20 Nov 2014 12:49:48 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:45473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrVrS-000189-E6 for submit@debbugs.gnu.org; Thu, 20 Nov 2014 12:49:42 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrVrM-0005Qs-IR for bug-gnu-emacs@gnu.org; Thu, 20 Nov 2014 12:49:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrVrG-000156-Mj for bug-gnu-emacs@gnu.org; Thu, 20 Nov 2014 12:49:36 -0500 Original-Received: from mail-qg0-f45.google.com ([209.85.192.45]:44921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrVrG-00014r-JH for bug-gnu-emacs@gnu.org; Thu, 20 Nov 2014 12:49:30 -0500 Original-Received: by mail-qg0-f45.google.com with SMTP id f51so2441396qge.32 for ; Thu, 20 Nov 2014 09:49:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=ntv6v5fwH4JoLojp7lmjQVydT4GeMAOD/aZ67koQGjs=; b=RTblzzy6ood9762lvo7uoG/iEgyLdinoOO0KSgz0RV+yzkYpT7VAMjJ/L/+A5NMHl7 UU3aX7Su3wcoBjcB6+n5oeAPmSXajuakq/6bS/HGtFO7YLW14hA8NoYOUR+7GecZcRaZ VATgITiJ9dJ0Y2bjyiD1zrxRGFvS0m+dFlhdl8szEfaw4tUJ6Fs1ChOIgoOicWoiqfio 64Ga4L4e0J8t0/X3MkvB0D6vyDbXPa8gml/ir2IBnCzZukYC+/y27Zq/mJVjivcOXLQi EPGfvoOc0+EzJuEZk1qzsvack6FPA+YSvyJtKf6pGOy04y6LRq3rIoER6cvem2enJ3UB t1bQ== X-Gm-Message-State: ALoCoQmJRyzThPD7vPuXX6sqak8kuXErIWTGaxqLGX+IV1jG8MU0rZOiI4mdxIWldZ+GhHggwVBS X-Received: by 10.140.23.112 with SMTP id 103mr60294265qgo.73.1416505769368; Thu, 20 Nov 2014 09:49:29 -0800 (PST) Original-Received: from holos (c-73-163-124-41.hsd1.md.comcast.net. [73.163.124.41]) by mx.google.com with ESMTPSA id c3sm2552874qaa.14.2014.11.20.09.49.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Nov 2014 09:49:28 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96335 --- eww was simply saving the page :url as the title, instead of the :title lisp/ChangeLog | 4 ++++ lisp/net/eww.el | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 473a1f8..0fe765d 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,7 @@ +2014-11-20 Mark Oteiza (tiny change) + + * net/eww.el (eww-add-bookmark): Fix bookmark titles. + 2014-11-20 Eric S. Raymond * vc/vc-bzr.el, vc/vc-cvs.el, vc/vc-dav.el, vc/vc-git.el, diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 6746668..2c73a64 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1321,7 +1321,7 @@ Differences in #targets are ignored." (if (y-or-n-p "bookmark this page? ") (progn (let ((title (replace-regexp-in-string "[\n\t\r]" " " - (plist-get eww-data :url)))) + (plist-get eww-data :title)))) (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title)) (push (list :url (plist-get eww-data :url) :title title -- 2.1.3