all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mark Oteiza <mvoteiza@udel.edu>
To: 19127@debbugs.gnu.org
Subject: bug#19127: 25.0.50; [PATCH] * net/eww.el (eww-add-bookmark): Fix bookmark title
Date: Thu, 20 Nov 2014 12:49:28 -0500	[thread overview]
Message-ID: <87y4r5ep93.fsf@udel.edu> (raw)

---
eww was simply saving the page :url as the title, instead of the :title

 lisp/ChangeLog  | 4 ++++
 lisp/net/eww.el | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 473a1f8..0fe765d 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2014-11-20  Mark Oteiza  <mvoteiza@udel.edu>  (tiny change)
+
+	* net/eww.el (eww-add-bookmark): Fix bookmark titles.
+
 2014-11-20  Eric S. Raymond  <esr@snark>
 
 	* vc/vc-bzr.el, vc/vc-cvs.el, vc/vc-dav.el, vc/vc-git.el,
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 6746668..2c73a64 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1321,7 +1321,7 @@ Differences in #targets are ignored."
   (if (y-or-n-p "bookmark this page? ")
       (progn
 	(let ((title (replace-regexp-in-string "[\n\t\r]" " "
-					       (plist-get eww-data :url))))
+					       (plist-get eww-data :title))))
 	  (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title))
 	  (push (list :url (plist-get eww-data :url)
 		      :title title
-- 
2.1.3






             reply	other threads:[~2014-11-20 17:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 17:49 Mark Oteiza [this message]
2014-11-23 15:40 ` bug#19127: 25.0.50; [PATCH] * net/eww.el (eww-add-bookmark): Fix bookmark title Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4r5ep93.fsf@udel.edu \
    --to=mvoteiza@udel.edu \
    --cc=19127@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.