bug#19566: (unload-feature 'misearch) breaks isearch

bug#19566: (unload-feature 'misearch) breaks isearch

[Ivan Shmakov]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Package:  emacs
Severity: minor
Tags: patch

	Using unload-feature to unload misearch.el also undefines the
	autoloaded variables, which breaks isearch.el as it still uses
	them.

	Please thus consider the patch MIMEd.

	* lisp/misearch.el (multi-isearch-unload-function): New function
	to retain definitions of autoloaded variables when unloading.
	(misearch-unload-function): New alias.

-- 
FSF associate member #7257  np. The Middle Path — David Modica B6A0 230E 334A

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/diff, Size: 965 bytes --]

--- a/lisp/misearch.el
+++ b/lisp/misearch.el
@@ -377,6 +377,25 @@
     (goto-char (if isearch-forward (point-min) (point-max)))
     (isearch-forward-regexp nil t)))
 
+(defun multi-isearch-unload-function ()
+  "Remove autoloaded variables from `unload-function-defs-list'.
+Also prevent the feature from being reloaded via `isearch-mode-hook'."
+  (remove-hook 'isearch-mode-hook 'multi-isearch-setup)
+  (let ((defs (list (car unload-function-defs-list)))
+	(auto '(multi-isearch-next-buffer-function
+		multi-isearch-next-buffer-current-function
+		multi-isearch-current-buffer
+		multi-isearch-buffer-list multi-isearch-file-list)))
+    (dolist (def (cdr unload-function-defs-list))
+      (unless (and (symbolp def)
+		   (memq def auto))
+	(push def defs)))
+    (setq unload-function-defs-list (nreverse defs))
+    ;; .
+    nil))
+
+(defalias 'misearch-unload-function 'multi-isearch-unload-function)
+
 \f
 (provide 'multi-isearch)
 (provide 'misearch)

bug#19566: (unload-feature 'misearch) breaks isearch

[Juri Linkov]

> 	Using unload-feature to unload misearch.el also undefines the
> 	autoloaded variables, which breaks isearch.el as it still uses
> 	them.
>
> 	Please thus consider the patch MIMEd.
>
> 	* lisp/misearch.el (multi-isearch-unload-function): New function
> 	to retain definitions of autoloaded variables when unloading.
> 	(misearch-unload-function): New alias.

Even though I see no way to reproduce the test case which breaks isearch.el
(after unloading, isearch.el just re-loads misearch.el again), I agree that
we definitely should correctly unload them.

bug#19566: unloading support for misearch

[Ivan Shmakov]

Version: 25.1

	I’ve pushed the change proposed to ‘master’ last Saturday;
	closing.

commit 0aaa5d699bf95afb152317f0788b8e2d2042f59d
CommitDate: Sat Jan 17 19:35:52 2015 +0000

    Unloading support for misearch.

    * lisp/misearch.el (multi-isearch-unload-function): New function.
    (misearch-unload-function): New alias.

    Fixes: debbugs:19566

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A