From: Markus Triska <triska@metalevel.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 21526@debbugs.gnu.org
Subject: bug#21526: 24.5; prolog-mode: broken indentation for if-then-else construct
Date: Wed, 30 Sep 2015 08:38:45 +0200 [thread overview]
Message-ID: <87y4fo9zt6.fsf@metalevel.at> (raw)
In-Reply-To: <jwv8u7or5sr.fsf-monnier+bug#21526@gnu.org> (Stefan Monnier's message of "Tue, 29 Sep 2015 23:28:48 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> (c) Arguments of directives should be more indented. For example, a
>> directive whose arguments span several lines should look like this:
>>
>> :- multifile
>> pred1,
>> pred2,
>> pred3.
>
> I have no idea what "directives" are nor what the above "multifile"
> means nor what is its syntax. Does Bruda's code handle that?
Yes. All issues I reported so far are deviations from Stefan Bruda's
original version. His version also highlights DCG heads with zero
arguments correctly.
A directive starts with :- or ?- in a source file.
>
>> `prolog-keywords' contains the directives where a hanging indentation of
>> prolog-indent-width in subsequent lines would be very welcome.
>
> That's vague: what means "subsequent lines"?
> Anything until a "."? What about a ";" or a ":-" or a "-->"?
(:-)/1 can be read just like a Prolog rule, only without head. So, after
:-, I expect the same indentation like in a rule. A directive can
include any regular Prolog goal.
>> test_predicate(c) :- !,
>> test_goal1,
>> test_goal2.
>
> Should work now.
Awesome, thank you!
Regarding comments, one more thing I noticed is that in a multiline
comment like /* ... */, we actually expect a small indentation like:
/*
Hello, indented world!
*/
as in the default C mode, but currently get:
/*
Not indented.
*/
In Stefan Bruda's version, we get the former layout.
All the best,
Markus
next prev parent reply other threads:[~2015-09-30 6:38 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-20 13:02 bug#21526: 24.5; prolog-mode: broken indentation for if-then-else construct Markus Triska
2015-09-20 18:04 ` Stefan Monnier
2015-09-20 19:33 ` Markus Triska
2015-09-21 2:34 ` Stefan Monnier
2015-09-21 3:03 ` Stefan Monnier
2015-09-21 6:02 ` Markus Triska
2015-09-21 20:22 ` Stefan Monnier
2015-09-22 6:25 ` Markus Triska
2015-09-22 15:12 ` Stefan Monnier
2015-09-22 16:38 ` Markus Triska
2015-09-22 21:04 ` Markus Triska
2015-09-23 21:08 ` Markus Triska
2015-09-25 16:20 ` Markus Triska
2015-09-30 2:04 ` Stefan Monnier
2015-09-30 3:28 ` Stefan Monnier
2015-09-30 6:38 ` Markus Triska [this message]
2015-09-30 9:23 ` Stefan Monnier
2015-09-30 18:35 ` Markus Triska
2015-09-30 20:19 ` Stefan Monnier
2015-09-30 20:40 ` Markus Triska
2015-10-01 0:14 ` Stefan Monnier
2015-10-01 6:22 ` Markus Triska
2015-10-01 14:07 ` Stefan Monnier
2015-10-02 16:23 ` Markus Triska
2015-10-02 20:47 ` Stefan Monnier
2015-10-05 22:38 ` Markus Triska
2015-10-06 2:23 ` Stefan Monnier
2015-09-30 18:03 ` Markus Triska
2015-09-30 21:19 ` Stefan Monnier
2015-09-30 3:28 ` Stefan Monnier
2015-09-30 2:07 ` Stefan Monnier
2015-09-30 6:32 ` Markus Triska
2015-09-30 8:55 ` Stefan Monnier
2015-09-30 18:11 ` Markus Triska
2015-10-05 23:49 ` Markus Triska
2015-10-06 1:17 ` Stefan Monnier
2015-10-06 16:45 ` Markus Triska
2015-10-06 20:09 ` Stefan Monnier
2015-10-20 23:47 ` Markus Triska
2015-10-21 16:06 ` Stefan Monnier
2015-10-21 21:58 ` Markus Triska
2015-10-22 1:16 ` Stefan Monnier
2015-10-22 19:08 ` Markus Triska
2015-10-25 20:01 ` Stefan Monnier
2015-11-23 16:36 ` Stefan Monnier
2020-08-24 18:23 ` Lars Ingebrigtsen
2015-09-29 15:27 ` Stefan Monnier
2015-09-29 16:24 ` Markus Triska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4fo9zt6.fsf@metalevel.at \
--to=triska@metalevel.at \
--cc=21526@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.